From 303f99a43294dd4d215a6cf14e0d50ba5ee5bd54 Mon Sep 17 00:00:00 2001 From: Benjamin Sergeant Date: Fri, 1 May 2020 10:37:25 -0700 Subject: [PATCH] refine previous commit --- ixwebsocket/IXDNSLookup.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/ixwebsocket/IXDNSLookup.cpp b/ixwebsocket/IXDNSLookup.cpp index e3036f10..b67c4682 100644 --- a/ixwebsocket/IXDNSLookup.cpp +++ b/ixwebsocket/IXDNSLookup.cpp @@ -4,15 +4,16 @@ * Copyright (c) 2018 Machine Zone, Inc. All rights reserved. */ -// Try to disable unicode on Windows uwp +// +// On Windows Universal Platform (uwp), gai_strerror defaults behavior is to returns wchar_t +// which is different from all other platforms. We want the non unicode version. +// See https://github.com/microsoft/vcpkg/pull/11030 +// We could do this in IXNetSystem.cpp but so far we are only using gai_strerror in here. +// #ifdef _UNICODE #undef _UNICODE #endif -#ifdef UNICODE -#undef UNICODE -#endif - #include "IXDNSLookup.h" #include "IXNetSystem.h"