fix unittest warnings + remove trailing spaces

This commit is contained in:
Benjamin Sergeant
2019-09-12 11:43:52 -07:00
parent a55d4cdb76
commit 57086e28d8
25 changed files with 87 additions and 106 deletions

View File

@ -94,7 +94,7 @@ namespace ix
int port = _port;
std::string hostname(_hostname);
// We make the background thread doing the work a shared pointer
// We make the background thread doing the work a shared pointer
// instead of a member variable, because it can keep running when
// this object goes out of scope, in case of cancellation
auto t = std::make_shared<std::thread>(&DNSLookup::run, this, self, hostname, port);

View File

@ -80,7 +80,7 @@ namespace ix
int ret = select(maxfd + 1, &readfds, &writefds, &errorfds,
timeout != -1 ? &tv : NULL);
if (ret < 0)
if (ret < 0)
{
return ret;
}

View File

@ -54,7 +54,7 @@ namespace ix
// which crash in FD_SET as they are larger than FD_SETSIZE.
// Switching to ::poll does fix that.
//
// However poll isn't as portable as select and has bugs on Windows, so we should write a
// However poll isn't as portable as select and has bugs on Windows, so we should write a
// shim to fallback to select on those platforms.
// See https://github.com/mpv-player/mpv/pull/5203/files for such a select wrapper.
//