kapitan/IXWebSocket
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

http client: stop hardcoding Accept header, and use a default value if one is passed in 👭

Browse Source
This commit is contained in:
Benjamin Sergeant 2019-06-03 14:02:54 -07:00
parent 1e2a5ee21d
commit 6b933391e5
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ixwebsocket/IXHttpClient.cpp
View File

@ -74,7 +74,6 @@ namespace ix
std::stringstream ss; std::stringstream ss;
ss << verb << " " << path << " HTTP/1.1\r\n"; ss << verb << " " << path << " HTTP/1.1\r\n";
ss << "Host: " << host << "\r\n"; ss << "Host: " << host << "\r\n";
ss << "Accept: */*" << "\r\n";
if (args.compress) if (args.compress)
{ {
@ -87,6 +86,18 @@ namespace ix
ss << it.first << ": " << it.second << "\r\n"; ss << it.first << ": " << it.second << "\r\n";
} }
// Set a default Accept header if none is present
if (headers.find("Accept") == headers.end())
{
ss << "Accept: */*" << "\r\n";
}
// Set a default User agent if none is present
if (headers.find("User-Agent") == headers.end())
{
ss << "User-Agent: ixwebsocket" << "\r\n";
}
if (verb == kPost) if (verb == kPost)
{ {
ss << "Content-Length: " << body.size() << "\r\n"; ss << "Content-Length: " << body.size() << "\r\n";

2
test/IXHttpClientTest.cpp
View File

@ -64,7 +64,7 @@ TEST_CASE("http client", "[http]")
} }
#if defined(IXWEBSOCKET_USE_TLS) #if defined(IXWEBSOCKET_USE_TLS)
SECTION("Connect to a remote HTTP server") SECTION("Connect to a remote HTTPS server")
{ {
std::string url("https://httpbin.org/"); std::string url("https://httpbin.org/");