kapitan/IXWebSocket
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Handle overflow in IXExponentialBackoff.cpp

Browse Source
This commit is contained in:
Benjamin Sergeant 2022-02-17 09:17:02 -08:00 committed by GitHub
parent 90f19e0280
commit 7360333aca
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
ixwebsocket/IXExponentialBackoff.cpp
View File

@ -14,14 +14,27 @@ namespace ix
uint32_t maxWaitBetweenReconnectionRetries, uint32_t maxWaitBetweenReconnectionRetries,
uint32_t minWaitBetweenReconnectionRetries) uint32_t minWaitBetweenReconnectionRetries)
{ {
uint32_t waitTime = (retryCount < 26) ? (std::pow(2, retryCount) * 100) : 0; // It's easy with a power function to go beyond 2^32, and then
// have unexpected results, so prepare for that
const uint32_t maxRetryCountWithoutOverflow = 26;
uint32_t waitTime = 0;
if (retryCount < maxRetryCountWithoutOverflow)
{
waitTime = std::pow(2, retryCount) * 100;
}
if (waitTime < minWaitBetweenReconnectionRetries) if (waitTime < minWaitBetweenReconnectionRetries)
{ {
waitTime = minWaitBetweenReconnectionRetries; waitTime = minWaitBetweenReconnectionRetries;
} }
if (waitTime > maxWaitBetweenReconnectionRetries || waitTime == 0) if (waitTime > maxWaitBetweenReconnectionRetries)
{
waitTime = maxWaitBetweenReconnectionRetries;
}
if (retryCount >= maxRetryCountWithoutOverflow)
{ {
waitTime = maxWaitBetweenReconnectionRetries; waitTime = maxWaitBetweenReconnectionRetries;
} }