thread accepting connections can be cancelled/stopped externally

examples/echo_server/echo_server.cpp

@@ -67,6 +67,7 @@ int main(int argc, char** argv)
     }
 
     server.start();
+    server.wait();
 
     return 0;
 }

ixwebsocket/IXWebSocketServer.cpp

@@ -7,6 +7,7 @@
 #include "IXWebSocketServer.h"
 #include "IXWebSocketTransport.h"
 #include "IXWebSocket.h"
+#include "IXSocketConnect.h"
 
 #include <sstream>
 #include <future>
@@ -120,32 +121,53 @@ namespace ix
         _thread = std::thread(&WebSocketServer::run, this);
     }
 
+    void WebSocketServer::wait()
+    {
+        std::unique_lock<std::mutex> lock(_conditionVariableMutex);
+        _conditionVariable.wait(lock);
+    }
+
     // FIXME: we should cancel all the async per connections tasks
     void WebSocketServer::stop()
     {
         _stop = true;
         _thread.join();
         _stop = false;
+
+        _conditionVariable.notify_one();
     }
 
     void WebSocketServer::run()
     {
+        // Set the socket to non blocking mode, so that accept calls are not blocking
+        SocketConnect::configure(_serverFd);
+
         std::future<void> f;
 
         for (;;)
         {
+            if (_stop) return;
+
             // Accept a connection.
             struct sockaddr_in client; // client address information
             int clientFd;              // socket connected to client
             socklen_t addressLen = sizeof(socklen_t);
 
-            if ((clientFd = accept(_serverFd, (struct sockaddr *)&client, &addressLen)) == -1)
+            if ((clientFd = accept(_serverFd, (struct sockaddr *)&client, &addressLen)) < 0)
             {
-                // FIXME: that error should be propagated
+                if (errno == EWOULDBLOCK)
-                std::stringstream ss;
+                {
-                ss << "WebSocketServer::run() error accepting connection: "
+                    std::chrono::duration<double, std::milli> wait(10);
-                   << strerror(errno);
+                    std::this_thread::sleep_for(wait);
-                logError(ss.str());
+                }
+                else
+                {
+                    // FIXME: that error should be propagated
+                    std::stringstream ss;
+                    ss << "WebSocketServer::run() error accepting connection: "
+                       << strerror(errno);
+                    logError(ss.str());
+                }
                 continue;
             }
 

ixwebsocket/IXWebSocketServer.h

@@ -13,6 +13,7 @@
 #include <mutex>
 #include <functional>
 #include <memory>
+#include <condition_variable>
 
 #include "IXWebSocket.h"
 
@@ -29,6 +30,7 @@ namespace ix
 
         void setOnConnectionCallback(const OnConnectionCallback& callback);
         void start();
+        void wait();
 
         std::pair<bool, std::string> listen();
 
@@ -54,6 +56,9 @@ namespace ix
         std::atomic<bool> _stop;
         std::thread _thread;
 
+        std::condition_variable _conditionVariable;
+        std::mutex _conditionVariableMutex;
+
         const static std::string kDefaultHost;
 
         // Methods