kapitan/IXWebSocket
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

check max frame size (#119)

Browse Source
This commit is contained in:
Benjamin Sergeant 2019-10-28 21:53:31 -07:00 committed by GitHub
parent ebb31b4e87
commit c943e72c7b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ixwebsocket/IXWebSocketTransport.cpp
View File

@ -542,6 +542,13 @@ namespace ix
ws.masking_key[3] = 0; ws.masking_key[3] = 0;
} }
// Prevent integer overflow in the next conditional
const uint64_t maxFrameSize(1 << 63);
if (ws.N > maxFrameSize)
{
return;
}
if (_rxbuf.size() < ws.header_size + ws.N) if (_rxbuf.size() < ws.header_size + ws.N)
{ {
return; /* Need: ws.header_size+ws.N - _rxbuf.size() */ return; /* Need: ws.header_size+ws.N - _rxbuf.size() */