diff --git a/.github/workflows/ccpp.yml b/.github/workflows/ccpp.yml index c5204ff3..66218e03 100644 --- a/.github/workflows/ccpp.yml +++ b/.github/workflows/ccpp.yml @@ -37,17 +37,42 @@ jobs: - name: make test run: make test_tsan_mbedtls - win: + windows_mbedtls: runs-on: windows-latest steps: - uses: actions/checkout@v1 - uses: seanmiddleditch/gha-setup-vsdevenv@master + - run: | + vcpkg install zlib:x64-windows + vcpkg install mbedtls:x64-windows - run: | mkdir build cd build - cmake -DCMAKE_CXX_COMPILER=cl.exe -DUSE_WS=1 -DUSE_TEST=1 .. + cmake -DCMAKE_TOOLCHAIN_FILE=c:/vcpkg/scripts/buildsystems/vcpkg.cmake -DCMAKE_CXX_COMPILER=cl.exe -DUSE_MBED_TLS=1 -DUSE_TLS=1 -DUSE_WS=1 -DUSE_TEST=1 .. - run: cmake --build build - # Running the unittest does not work + # Running the unittest does not work, the binary cannot be found #- run: ../build/test/ixwebsocket_unittest.exe # working-directory: test + +# +# Windows with OpenSSL is working but disabled as it takes 13 minutes (10 for openssl) to build with vcpkg +# +# windows_openssl: +# runs-on: windows-latest +# steps: +# - uses: actions/checkout@v1 +# - uses: seanmiddleditch/gha-setup-vsdevenv@master +# - run: | +# vcpkg install zlib:x64-windows +# vcpkg install openssl:x64-windows +# - run: | +# mkdir build +# cd build +# cmake -DCMAKE_TOOLCHAIN_FILE=c:/vcpkg/scripts/buildsystems/vcpkg.cmake -DCMAKE_CXX_COMPILER=cl.exe -DUSE_OPEN_SSL=1 -DUSE_TLS=1 -DUSE_WS=1 -DUSE_TEST=1 .. +# - run: cmake --build build +# +# # Running the unittest does not work, the binary cannot be found +# #- run: ../build/test/ixwebsocket_unittest.exe +# # working-directory: test + diff --git a/CMakeLists.txt b/CMakeLists.txt index a3f40c3a..e2c1bd32 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -120,13 +120,14 @@ endif() option(USE_TLS "Enable TLS support" FALSE) if (USE_TLS) - if (WIN32) - option(USE_MBED_TLS "Use Mbed TLS" ON) - else() - option(USE_MBED_TLS "Use Mbed TLS" OFF) - endif() + option(USE_MBED_TLS "Use Mbed TLS" OFF) option(USE_OPEN_SSL "Use OpenSSL" OFF) + # default to mbedtls on windows if nothing is configured + if (WIN32 AND NOT USE_OPEN_SSL AND NOT USE_MBED_TLS) + option(USE_MBED_TLS "Use Mbed TLS" ON) + endif() + if (USE_MBED_TLS) list( APPEND IXWEBSOCKET_HEADERS ixwebsocket/IXSocketMbedTLS.h) list( APPEND IXWEBSOCKET_SOURCES ixwebsocket/IXSocketMbedTLS.cpp) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 9f07b286..3cac97c2 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -1,6 +1,10 @@ # Changelog All changes to this project will be documented in this file. +## [9.2.0] - 2020-04-04 + +(windows) ci: windows build with TLS (mbedtls) + verify that we can be build with OpenSSL + ## [9.1.9] - 2020-03-30 (cobra to statsd bot) add ability to extract a numerical value and send a timer event to statsd, with the --timer option diff --git a/ixwebsocket/IXWebSocketVersion.h b/ixwebsocket/IXWebSocketVersion.h index f69be85d..bc76c854 100644 --- a/ixwebsocket/IXWebSocketVersion.h +++ b/ixwebsocket/IXWebSocketVersion.h @@ -6,4 +6,4 @@ #pragma once -#define IX_WEBSOCKET_VERSION "9.1.9" +#define IX_WEBSOCKET_VERSION "9.2.0"