c2d497abc5
* Fix unsafe calls and safeguard WebSocketMessage from being called w/ temporaries * Use unnamed namespace to express internal linkage * Avoid returning references that are mutex protected Motivation for this MR The antipattern of returning references to mutex protected members was removed. Since a caller can hold the reference it would make all class level locking meaningless. Instead values are returned. The IXWebSocketPerMessageDeflateOptions class was shrunk by 7 bytes (1 padding + 2*3) after changing the int members to the used uint8_t; side effects of that were handled. An inefficient "string -> int" was replaced by standard library. As seen here http://coliru.stacked-crooked.com/a/46b5990bafb9c626 this gives an order of magnitude better performance.
48 lines
1.4 KiB
C++
48 lines
1.4 KiB
C++
/*
|
|
* IXWebSocketPerMessageDeflateOptions.h
|
|
* Author: Benjamin Sergeant
|
|
* Copyright (c) 2018 Machine Zone, Inc. All rights reserved.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <string>
|
|
|
|
namespace ix
|
|
{
|
|
class WebSocketPerMessageDeflateOptions
|
|
{
|
|
public:
|
|
WebSocketPerMessageDeflateOptions(
|
|
bool enabled = false,
|
|
bool clientNoContextTakeover = false,
|
|
bool serverNoContextTakeover = false,
|
|
uint8_t clientMaxWindowBits = kDefaultClientMaxWindowBits,
|
|
uint8_t serverMaxWindowBits = kDefaultServerMaxWindowBits);
|
|
|
|
WebSocketPerMessageDeflateOptions(std::string extension);
|
|
|
|
std::string generateHeader();
|
|
bool enabled() const;
|
|
bool getClientNoContextTakeover() const;
|
|
bool getServerNoContextTakeover() const;
|
|
uint8_t getServerMaxWindowBits() const;
|
|
uint8_t getClientMaxWindowBits() const;
|
|
|
|
static bool startsWith(const std::string& str, const std::string& start);
|
|
static std::string removeSpaces(const std::string& str);
|
|
|
|
static uint8_t const kDefaultClientMaxWindowBits;
|
|
static uint8_t const kDefaultServerMaxWindowBits;
|
|
|
|
private:
|
|
bool _enabled;
|
|
bool _clientNoContextTakeover;
|
|
bool _serverNoContextTakeover;
|
|
uint8_t _clientMaxWindowBits;
|
|
uint8_t _serverMaxWindowBits;
|
|
|
|
void sanitizeClientMaxWindowBits();
|
|
};
|
|
} // namespace ix
|