more tests disabled

disable IXWebSocketPingTimeoutTest
server code / add dedicated thread to close/join terminated connection threads
2019-05-13 12:37:27 -07:00 · 2019-05-13 12:26:40 -07:00 · 2019-05-13 12:20:03 -07:00 · 2019-05-13 09:33:14 -07:00
32 changed files with 489 additions and 681 deletions
--- a/.travis.yml
+++ b/.travis.yml
@ -1,36 +1,17 @@
-language: bash
+language: cpp
+dist: xenial
+
+compiler:
+  - gcc
+  - clang
+os:
+  - linux
+  - osx

 matrix:
-  include:
-    # macOS
-    - os: osx
-      compiler: clang
-      script:
-        - python test/run.py
-        - make ws
+  exclude:
+    # GCC fails on recent Travis OSX images.
+    - compiler: gcc
+      os: osx

-    # Linux
-    - os: linux
-      dist: xenial
-      script: 
-        - python test/run.py
-        - make ws
-      env:
-        - CC=gcc
-        - CXX=g++
-
-    # Clang + Linux disabled for now
-    # - os: linux
-    #   dist: xenial
-    #   script: python test/run.py
-    #   env:
-    #     - CC=clang 
-    #     - CXX=clang++
-
-    # Windows
-    - os: windows
-      env:
-        - CMAKE_PATH="/c/Program Files/CMake/bin"
-      script: 
-        - export PATH=$CMAKE_PATH:$PATH
-        - python test/run.py
+script: python test/run.py
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@ -41,7 +41,6 @@ set( IXWEBSOCKET_SOURCES
    ixwebsocket/IXSelectInterrupt.cpp
    ixwebsocket/IXSelectInterruptFactory.cpp
    ixwebsocket/IXConnectionState.cpp
-    ixwebsocket/IXWebSocketCloseConstants.cpp
 )

 set( IXWEBSOCKET_HEADERS
@ -71,7 +70,6 @@ set( IXWEBSOCKET_HEADERS
    ixwebsocket/IXSelectInterrupt.h
    ixwebsocket/IXSelectInterruptFactory.h
    ixwebsocket/IXConnectionState.h
-    ixwebsocket/IXWebSocketCloseConstants.h
 )

 if (UNIX)
@ -157,6 +155,6 @@ install(TARGETS ixwebsocket
        PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_PREFIX}/include/ixwebsocket/
 )

-if (USE_WS)
+if (NOT WIN32)
    add_subdirectory(ws)
 endif()
--- a/docker/Dockerfile.fedora
+++ b/docker/Dockerfile.fedora
@ -16,7 +16,6 @@ ENV PATH="${CMAKE_BIN_PATH}:${PATH}"

 RUN yum install -y python
 RUN yum install -y libtsan
-RUN yum install -y zlib-devel

 COPY . .
 # RUN ["make", "test"]
--- a/ixwebsocket/IXHttpClient.h
+++ b/ixwebsocket/IXHttpClient.h
@ -19,7 +19,7 @@

 namespace ix
 {
-    enum class HttpErrorCode : int
+    enum class HttpErrorCode
    {
        Ok                       = 0,
        CannotConnect            = 1,
--- a/ixwebsocket/IXSocket.cpp
+++ b/ixwebsocket/IXSocket.cpp
@ -129,7 +129,7 @@ namespace ix
    }

    // Wake up from poll/select by writing to the pipe which is watched by select
-    bool Socket::wakeUpFromPoll(uint64_t wakeUpCode)
+    bool Socket::wakeUpFromPoll(uint8_t wakeUpCode)
    {
        return _selectInterrupt->notify(wakeUpCode);
    }
--- a/ixwebsocket/IXSocket.h
+++ b/ixwebsocket/IXSocket.h
@ -57,7 +57,7 @@ namespace ix

        // Functions to check whether there is activity on the socket
        PollResultType poll(int timeoutMs = kDefaultPollTimeout);
-        bool wakeUpFromPoll(uint64_t wakeUpCode);
+        bool wakeUpFromPoll(uint8_t wakeUpCode);

        PollResultType isReadyToWrite(int timeoutMs);
        PollResultType isReadyToRead(int timeoutMs);
--- a/ixwebsocket/IXWebSocket.cpp
+++ b/ixwebsocket/IXWebSocket.cpp
@ -142,10 +142,9 @@ namespace ix
        _thread = std::thread(&WebSocket::run, this);
    }

-    void WebSocket::stop(uint16_t code,
-                         const std::string& reason)
+    void WebSocket::stop()
    {
-        close(code, reason);
+        close();

        if (_thread.joinable())
        {
@ -263,7 +262,7 @@ namespace ix
                    connectErr.wait_time = duration.count();
                    connectErr.retries = retries;
                }
-
+                
                connectErr.reason      = status.errorStr;
                connectErr.http_status = status.http_status;

@ -293,9 +292,6 @@ namespace ix
                break;
            }

-            // We cannot enter poll which might block forever if we are stopping
-            if (_stop) break;
-
            // 2. Poll to see if there's any new data available
            WebSocketTransport::PollResult pollResult = _ws.poll();

@ -463,11 +459,6 @@ namespace ix
        _automaticReconnection = false;
    }

-    bool WebSocket::isAutomaticReconnectionEnabled() const
-    {
-        return _automaticReconnection;
-    }
-
    size_t WebSocket::bufferedAmount() const
    {
        return _ws.bufferedAmount();
--- a/ixwebsocket/IXWebSocket.h
+++ b/ixwebsocket/IXWebSocket.h
@ -19,7 +19,6 @@
 #include "IXWebSocketSendInfo.h"
 #include "IXWebSocketPerMessageDeflateOptions.h"
 #include "IXWebSocketHttpHeaders.h"
-#include "IXWebSocketCloseConstants.h"
 #include "IXProgressCallback.h"

 namespace ix
@ -100,10 +99,8 @@ namespace ix

        // Run asynchronously, by calling start and stop.
        void start();
-
        // stop is synchronous
-        void stop(uint16_t code = WebSocketCloseConstants::kNormalClosureCode,
-                  const std::string& reason = WebSocketCloseConstants::kNormalClosureMessage);
+        void stop();

        // Run in blocking mode, by connecting first manually, and then calling run.
        WebSocketInitResult connect(int timeoutSecs);
@ -116,6 +113,8 @@ namespace ix
                                   const OnProgressCallback& onProgressCallback = nullptr);
        WebSocketSendInfo ping(const std::string& text);

+        // A close frame can provide a code and a reason
+        // FIXME: use constants
        void close(uint16_t code = 1000,
                   const std::string& reason = "Normal closure");

@ -135,7 +134,6 @@ namespace ix

        void enableAutomaticReconnection();
        void disableAutomaticReconnection();
-        bool isAutomaticReconnectionEnabled() const;

    private:

--- a/ixwebsocket/IXWebSocketCloseConstants.cpp
+++ b/ixwebsocket/IXWebSocketCloseConstants.cpp
@ -1,23 +0,0 @@
-/*
- *  IXWebSocketCloseConstants.cpp
- *  Author: Benjamin Sergeant
- *  Copyright (c) 2019 Machine Zone, Inc. All rights reserved.
- */
-
-#include "IXWebSocketCloseConstants.h"
-
-namespace ix
-{
-    const uint16_t WebSocketCloseConstants::kNormalClosureCode(1000);
-    const uint16_t WebSocketCloseConstants::kInternalErrorCode(1011);
-    const uint16_t WebSocketCloseConstants::kAbnormalCloseCode(1006);
-    const uint16_t WebSocketCloseConstants::kProtocolErrorCode(1002);
-    const uint16_t WebSocketCloseConstants::kNoStatusCodeErrorCode(1005);
-
-    const std::string WebSocketCloseConstants::kNormalClosureMessage("Normal closure");
-    const std::string WebSocketCloseConstants::kInternalErrorMessage("Internal error");
-    const std::string WebSocketCloseConstants::kAbnormalCloseMessage("Abnormal closure");
-    const std::string WebSocketCloseConstants::kPingTimeoutMessage("Ping timeout");
-    const std::string WebSocketCloseConstants::kProtocolErrorMessage("Protocol error");
-    const std::string WebSocketCloseConstants::kNoStatusCodeErrorMessage("No status code");
-}
--- a/ixwebsocket/IXWebSocketCloseConstants.h
+++ b/ixwebsocket/IXWebSocketCloseConstants.h
@ -1,29 +0,0 @@
-/*
- *  IXWebSocketCloseConstants.h
- *  Author: Benjamin Sergeant
- *  Copyright (c) 2019 Machine Zone, Inc. All rights reserved.
- */
-
-#pragma once
-
-#include <cstdint>
-#include <string>
-
-namespace ix
-{
-    struct WebSocketCloseConstants
-    {
-        static const uint16_t kNormalClosureCode;
-        static const uint16_t kInternalErrorCode;
-        static const uint16_t kAbnormalCloseCode;
-        static const uint16_t kProtocolErrorCode;
-        static const uint16_t kNoStatusCodeErrorCode;
-
-        static const std::string kNormalClosureMessage;
-        static const std::string kInternalErrorMessage;
-        static const std::string kAbnormalCloseMessage;
-        static const std::string kPingTimeoutMessage;
-        static const std::string kProtocolErrorMessage;
-        static const std::string kNoStatusCodeErrorMessage;
-    };
-}
--- a/ixwebsocket/IXWebSocketTransport.cpp
+++ b/ixwebsocket/IXWebSocketTransport.cpp
@ -74,11 +74,21 @@ namespace ix
    const int WebSocketTransport::kClosingMaximumWaitingDelayInMs(200);
    constexpr size_t WebSocketTransport::kChunkSize;

+    const uint16_t WebSocketTransport::kInternalErrorCode(1011);
+    const uint16_t WebSocketTransport::kAbnormalCloseCode(1006);
+    const uint16_t WebSocketTransport::kProtocolErrorCode(1002);
+    const uint16_t WebSocketTransport::kNoStatusCodeErrorCode(1005);
+    const std::string WebSocketTransport::kInternalErrorMessage("Internal error");
+    const std::string WebSocketTransport::kAbnormalCloseMessage("Abnormal closure");
+    const std::string WebSocketTransport::kPingTimeoutMessage("Ping timeout");
+    const std::string WebSocketTransport::kProtocolErrorMessage("Protocol error");
+    const std::string WebSocketTransport::kNoStatusCodeErrorMessage("No status code");
+
    WebSocketTransport::WebSocketTransport() :
        _useMask(true),
        _readyState(ReadyState::CLOSED),
-        _closeCode(WebSocketCloseConstants::kInternalErrorCode),
-        _closeReason(WebSocketCloseConstants::kInternalErrorMessage),
+        _closeCode(kInternalErrorCode),
+        _closeReason(kInternalErrorMessage),
        _closeWireSize(0),
        _closeRemote(false),
        _enablePerMessageDeflate(false),
@ -130,8 +140,6 @@ namespace ix
    WebSocketInitResult WebSocketTransport::connectToUrl(const std::string& url,
                                                         int timeoutSecs)
    {
-        std::lock_guard<std::mutex> lock(_socketMutex);
-
        std::string protocol, host, path, query;
        int port;

@ -141,8 +149,8 @@ namespace ix
                                       std::string("Could not parse URL ") + url);
        }

-        std::string errorMsg;
        bool tls = protocol == "wss";
+        std::string errorMsg;
        _socket = createSocket(tls, errorMsg);

        if (!_socket)
@ -168,8 +176,6 @@ namespace ix
    // Server
    WebSocketInitResult WebSocketTransport::connectToSocket(int fd, int timeoutSecs)
    {
-        std::lock_guard<std::mutex> lock(_socketMutex);
-
        // Server should not mask the data it sends to the client
        _useMask = false;

@ -209,8 +215,8 @@ namespace ix
        {
            std::lock_guard<std::mutex> lock(_closeDataMutex);
            _onCloseCallback(_closeCode, _closeReason, _closeWireSize, _closeRemote);
-            _closeCode = WebSocketCloseConstants::kInternalErrorCode;
-            _closeReason = WebSocketCloseConstants::kInternalErrorMessage;
+            _closeCode = kInternalErrorCode;
+            _closeReason = kInternalErrorMessage;
            _closeWireSize = 0;
            _closeRemote = false;
        }
@ -232,7 +238,7 @@ namespace ix
        {
            std::lock_guard<std::mutex> lock(_lastSendPingTimePointMutex);
            _lastSendPingTimePoint = std::chrono::steady_clock::now();
-        }
+        } 
        {
            std::lock_guard<std::mutex> lock(_lastReceivePongTimePointMutex);
            _lastReceivePongTimePoint = std::chrono::steady_clock::now();
@ -280,8 +286,7 @@ namespace ix
            // ping response (PONG) exceeds the maximum delay, then close the connection
            if (pingTimeoutExceeded())
            {
-                close(WebSocketCloseConstants::kInternalErrorCode,
-                      WebSocketCloseConstants::kPingTimeoutMessage);
+                close(kInternalErrorCode, kPingTimeoutMessage);
            }
            // If ping is enabled and no ping has been sent for a duration
            // exceeding our ping interval, send a ping to the server.
@ -292,7 +297,7 @@ namespace ix
                sendPing(ss.str());
            }
        }
-
+        
        // No timeout if state is not OPEN, otherwise computed
        // pingIntervalOrTimeoutGCD (equals to -1 if no ping and no ping timeout are set)
        int lastingTimeoutDelayInMs = (_readyState != ReadyState::OPEN) ? 0 : _pingIntervalOrTimeoutGCDSecs;
@ -305,30 +310,19 @@ namespace ix
            if (now >= _nextGCDTimePoint)
            {
                _nextGCDTimePoint = now + std::chrono::seconds(_pingIntervalOrTimeoutGCDSecs);
-
+            
                lastingTimeoutDelayInMs = _pingIntervalOrTimeoutGCDSecs * 1000;
            }
-            else
+            else 
            {
                lastingTimeoutDelayInMs = (int)std::chrono::duration_cast<std::chrono::milliseconds>(_nextGCDTimePoint - now).count();
            }
        }

 #ifdef _WIN32
-        // Windows does not have select interrupt capabilities, so wait with a small timeout
-        if (lastingTimeoutDelayInMs <= 0)
-        {
-            lastingTimeoutDelayInMs = 20;
-        }
+        if (lastingTimeoutDelayInMs <= 0) lastingTimeoutDelayInMs = 20;
 #endif

-        // If we are requesting a cancellation, pass in a positive and small timeout
-        // to never poll forever without a timeout.
-        if (_requestInitCancellation)
-        {
-            lastingTimeoutDelayInMs = 100;
-        }
-
        // poll the socket
        PollResultType pollResult = _socket->poll(lastingTimeoutDelayInMs);

@ -344,7 +338,7 @@ namespace ix

                if (result == PollResultType::Error)
                {
-                    closeSocket();
+                    _socket->close();
                    setReadyState(ReadyState::CLOSED);
                    break;
                }
@ -368,8 +362,8 @@ namespace ix
                {
                    // if there are received data pending to be processed, then delay the abnormal closure
                    // to after dispatch (other close code/reason could be read from the buffer)
-
-                    closeSocket();
+                    
+                    _socket->close();

                    return PollResult::AbnormalClose;
                }
@ -383,18 +377,18 @@ namespace ix
        }
        else if (pollResult == PollResultType::Error)
        {
-            closeSocket();
+            _socket->close();
        }
        else if (pollResult == PollResultType::CloseRequest)
        {
-            closeSocket();
+            _socket->close();
        }

        if (_readyState == ReadyState::CLOSING && closingDelayExceeded())
        {
            _rxbuf.clear();
            // close code and reason were set when calling close()
-            closeSocket();
+            _socket->close();
            setReadyState(ReadyState::CLOSED);
        }

@ -626,8 +620,8 @@ namespace ix
                else
                {
                    // no close code received
-                    code = WebSocketCloseConstants::kNoStatusCodeErrorCode;
-                    reason = WebSocketCloseConstants::kNoStatusCodeErrorMessage;
+                    code = kNoStatusCodeErrorCode;
+                    reason = kNoStatusCodeErrorMessage;
                }

                // We receive a CLOSE frame from remote and are NOT the ones who triggered the close
@ -661,9 +655,8 @@ namespace ix
            else
            {
                // Unexpected frame type
-                close(WebSocketCloseConstants::kProtocolErrorCode,
-                      WebSocketCloseConstants::kProtocolErrorMessage,
-                      _rxbuf.size());
+
+                close(kProtocolErrorCode, kProtocolErrorMessage, _rxbuf.size());
            }

            // Erase the message that has been processed from the input/read buffer
@ -680,15 +673,13 @@ namespace ix
            // if we previously closed the connection (CLOSING state), then set state to CLOSED (code/reason were set before)
            if (_readyState == ReadyState::CLOSING)
            {
-                closeSocket();
+                _socket->close();
                setReadyState(ReadyState::CLOSED);
            }
-            // if we weren't closing, then close using abnormal close code and message
+            // if we weren't closing, then close using abnormal close code and message 
            else if (_readyState != ReadyState::CLOSED)
            {
-                closeSocketAndSwitchToClosedState(WebSocketCloseConstants::kAbnormalCloseCode,
-                                                  WebSocketCloseConstants::kAbnormalCloseMessage,
-                                                  0, false);
+                closeSocketAndSwitchToClosedState(kAbnormalCloseCode, kAbnormalCloseMessage, 0, false);
            }
        }
    }
@ -958,19 +949,13 @@ namespace ix
                        _enablePerMessageDeflate, onProgressCallback);
    }

-    ssize_t WebSocketTransport::send()
-    {
-        std::lock_guard<std::mutex> lock(_socketMutex);
-        return _socket->send((char*)&_txbuf[0], _txbuf.size());
-    }
-
    void WebSocketTransport::sendOnSocket()
    {
        std::lock_guard<std::mutex> lock(_txbufMutex);

        while (_txbuf.size())
        {
-            ssize_t ret = send();
+            ssize_t ret = _socket->send((char*)&_txbuf[0], _txbuf.size());

            if (ret < 0 && Socket::isWaitNeeded())
            {
@ -978,7 +963,8 @@ namespace ix
            }
            else if (ret <= 0)
            {
-                closeSocket();
+                _socket->close();
+
                setReadyState(ReadyState::CLOSED);
                break;
            }
@ -994,7 +980,7 @@ namespace ix
        bool compress = false;

        // if a status is set/was read
-        if (code != WebSocketCloseConstants::kNoStatusCodeErrorCode)
+        if (code != kNoStatusCodeErrorCode)
        {
            // See list of close events here:
            // https://developer.mozilla.org/en-US/docs/Web/API/CloseEvent
@ -1012,17 +998,9 @@ namespace ix
        }
    }

-    void WebSocketTransport::closeSocket()
+    void WebSocketTransport::closeSocketAndSwitchToClosedState(uint16_t code, const std::string& reason, size_t closeWireSize, bool remote)
    {
-        std::lock_guard<std::mutex> lock(_socketMutex);
        _socket->close();
-    }
-
-    void WebSocketTransport::closeSocketAndSwitchToClosedState(
-        uint16_t code, const std::string& reason, size_t closeWireSize, bool remote)
-    {
-        closeSocket();
-
        {
            std::lock_guard<std::mutex> lock(_closeDataMutex);
            _closeCode = code;
@ -1030,13 +1008,10 @@ namespace ix
            _closeWireSize = closeWireSize;
            _closeRemote = remote;
        }
-
        setReadyState(ReadyState::CLOSED);
-        _requestInitCancellation = false;
    }

-    void WebSocketTransport::close(
-        uint16_t code, const std::string& reason, size_t closeWireSize, bool remote)
+    void WebSocketTransport::close(uint16_t code, const std::string& reason, size_t closeWireSize, bool remote)
    {
        _requestInitCancellation = true;

--- a/ixwebsocket/IXWebSocketTransport.h
+++ b/ixwebsocket/IXWebSocketTransport.h
@ -25,7 +25,6 @@
 #include "IXCancellationRequest.h"
 #include "IXWebSocketHandshake.h"
 #include "IXProgressCallback.h"
-#include "IXWebSocketCloseConstants.h"

 namespace ix
 {
@ -92,14 +91,11 @@ namespace ix
                                   const OnProgressCallback& onProgressCallback);
        WebSocketSendInfo sendPing(const std::string& message);

-        void close(uint16_t code = WebSocketCloseConstants::kNormalClosureCode,
-                   const std::string& reason = WebSocketCloseConstants::kNormalClosureMessage,
+        void close(uint16_t code = 1000,
+                   const std::string& reason = "Normal closure",
                   size_t closeWireSize = 0,
                   bool remote = false);

-        void closeSocket();
-        ssize_t send();
-
        ReadyState getReadyState() const;
        void setReadyState(ReadyState readyState);
        void setOnCloseCallback(const OnCloseCallback& onCloseCallback);
@ -155,7 +151,6 @@ namespace ix

        // Underlying TCP socket
        std::shared_ptr<Socket> _socket;
-        std::mutex _socketMutex;

        // Hold the state of the connection (OPEN, CLOSED, etc...)
        std::atomic<ReadyState> _readyState;
@ -174,11 +169,22 @@ namespace ix

        // Used to cancel dns lookup + socket connect + http upgrade
        std::atomic<bool> _requestInitCancellation;
-
+              
        mutable std::mutex _closingTimePointMutex;
        std::chrono::time_point<std::chrono::steady_clock>_closingTimePoint;
        static const int kClosingMaximumWaitingDelayInMs;

+        // Constants for dealing with closing conneections
+        static const uint16_t kInternalErrorCode;
+        static const uint16_t kAbnormalCloseCode;
+        static const uint16_t kProtocolErrorCode;
+        static const uint16_t kNoStatusCodeErrorCode;
+        static const std::string kInternalErrorMessage;
+        static const std::string kAbnormalCloseMessage;
+        static const std::string kPingTimeoutMessage;
+        static const std::string kProtocolErrorMessage;
+        static const std::string kNoStatusCodeErrorMessage;
+
        // enable auto response to ping
        std::atomic<bool> _enablePong;
        static const bool kDefaultEnablePong;
--- a/ixwebsocket/LUrlParser.cpp
+++ b/ixwebsocket/LUrlParser.cpp
@ -1,21 +1,21 @@
 /*
 * Lightweight URL & URI parser (RFC 1738, RFC 3986)
 * https://github.com/corporateshark/LUrlParser
- *
+ * 
 * The MIT License (MIT)
- *
+ * 
 * Copyright (C) 2015 Sergey Kosarevsky (sk@linderdaum.com)
- *
+ * 
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
- *
+ * 
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
- *
+ * 
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
--- a/ixwebsocket/LUrlParser.h
+++ b/ixwebsocket/LUrlParser.h
@ -1,21 +1,21 @@
 /*
 * Lightweight URL & URI parser (RFC 1738, RFC 3986)
 * https://github.com/corporateshark/LUrlParser
- *
+ * 
 * The MIT License (MIT)
- *
+ * 
 * Copyright (C) 2015 Sergey Kosarevsky (sk@linderdaum.com)
- *
+ * 
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
- *
+ * 
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
- *
+ * 
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
--- a/10
+++ b/10
@ -9,10 +9,7 @@ install: brew
 # on osx it is good practice to make /usr/local user writable
 # sudo chown -R `whoami`/staff /usr/local
 brew:
-	mkdir -p build && (cd build ; cmake -DUSE_TLS=1 -DUSE_WS=1 .. ; make -j install)
-
-ws:
-	mkdir -p build && (cd build ; cmake -DUSE_TLS=1 -DUSE_WS=1 .. ; make -j)
+	mkdir -p build && (cd build ; cmake -DUSE_TLS=1 .. ; make -j install)

 uninstall:
 	xargs rm -fv < build/install_manifest.txt
@ -51,8 +48,8 @@ test_server:
 test:
 	python2.7 test/run.py

-ws_test: ws
-	(cd ws ; env DEBUG=1 PATH=../ws/build:$$PATH bash test_ws.sh)
+ws_test: all
+	(cd ws ; bash test_ws.sh)

 # For the fork that is configured with appveyor
 rebase_upstream:
@ -67,4 +64,3 @@ install_cmake_for_linux:

 .PHONY: test
 .PHONY: build
-.PHONY: ws
--- a/test/CMakeLists.txt
+++ b/test/CMakeLists.txt
@ -7,7 +7,7 @@ project (ixwebsocket_unittest)

 set (CMAKE_CXX_STANDARD 14)

-if (NOT WIN32)
+if (UNIX)
  set(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/../third_party/sanitizers-cmake/cmake" ${CMAKE_MODULE_PATH})
  find_package(Sanitizers)
  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=thread")
@ -31,30 +31,29 @@ set (SOURCES
  ../third_party/msgpack11/msgpack11.cpp
  ../ws/ixcore/utils/IXCoreLogger.cpp

+  IXDNSLookupTest.cpp
  IXSocketTest.cpp
  IXSocketConnectTest.cpp
  IXWebSocketServerTest.cpp
+  IXWebSocketPingTest.cpp
  IXWebSocketTestConnectionDisconnection.cpp
  IXUrlParserTest.cpp
  IXWebSocketServerTest.cpp
+  IXWebSocketPingTest.cpp
 )

 # Some unittest don't work on windows yet
 if (UNIX)
  list(APPEND SOURCES
-    IXDNSLookupTest.cpp
+    # IXWebSocketPingTimeoutTest.cpp # This test isn't reliable # (multiple platforms), disabling in master
+    # IXWebSocketCloseTest.cpp       # 
    cmd_websocket_chat.cpp
  )
 endif()

-# Disable tests for now that are failing or not reliable
-# IXWebSocketPingTest.cpp
-# IXWebSocketPingTimeoutTest.cpp
-# IXWebSocketCloseTest.cpp
-
 add_executable(ixwebsocket_unittest ${SOURCES})

-if (NOT WIN32)
+if (UNIX)
  add_sanitizers(ixwebsocket_unittest)
 endif()

--- a/test/IXSocketConnectTest.cpp
+++ b/test/IXSocketConnectTest.cpp
@ -17,12 +17,8 @@ TEST_CASE("socket_connect", "[net]")
 {
    SECTION("Test connecting to a known hostname")
    {
-        int port = getFreePort();
-        ix::WebSocketServer server(port);
-        REQUIRE(startWebSocketEchoServer(server));
-
        std::string errMsg;
-        int fd = SocketConnect::connect("127.0.0.1", port, errMsg, [] { return false; });
+        int fd = SocketConnect::connect("www.google.com", 80, errMsg, [] { return false; });
        std::cerr << "Error message: " << errMsg << std::endl;
        REQUIRE(fd != -1);
    }
@ -38,13 +34,9 @@ TEST_CASE("socket_connect", "[net]")

    SECTION("Test connecting to a good hostname, with cancellation")
    {
-        int port = getFreePort();
-        ix::WebSocketServer server(port);
-        REQUIRE(startWebSocketEchoServer(server));
-
        std::string errMsg;
        // The callback returning true means we are requesting cancellation
-        int fd = SocketConnect::connect("127.0.0.1", port, errMsg, [] { return true; });
+        int fd = SocketConnect::connect("www.google.com", 80, errMsg, [] { return true; });
        std::cerr << "Error message: " << errMsg << std::endl;
        REQUIRE(fd == -1);
    }
--- a/test/IXSocketTest.cpp
+++ b/test/IXSocketTest.cpp
@ -53,17 +53,13 @@ namespace ix

 TEST_CASE("socket", "[socket]")
 {
-    SECTION("Connect to a local websocket server over a free port. Send GET request without header. Should return 400")
+    SECTION("Connect to google HTTP server. Send GET request without header. Should return 200")
    {
-        // Start a server first which we'll hit with our socket code
-        int port = getFreePort();
-        ix::WebSocketServer server(port);
-        REQUIRE(startWebSocketEchoServer(server));
-
        std::string errMsg;
        bool tls = false;
        std::shared_ptr<Socket> socket = createSocket(tls, errMsg);
-        std::string host("127.0.0.1");
+        std::string host("www.google.com");
+        int port = 80;

        std::stringstream ss;
        ss << "GET / HTTP/1.1\r\n";
@ -71,14 +67,14 @@ TEST_CASE("socket", "[socket]")
        ss << "\r\n";
        std::string request(ss.str());

-        int expectedStatus = 400;
+        int expectedStatus = 200;
        int timeoutSecs = 3;

        testSocket(host, port, request, socket, expectedStatus, timeoutSecs);
    }

 #if defined(__APPLE__) || defined(__linux__)
-    SECTION("Connect to google HTTPS server over port 443. Send GET request without header. Should return 200")
+    SECTION("Connect to google HTTPS server. Send GET request without header. Should return 200")
    {
        std::string errMsg;
        bool tls = true;
--- a/test/IXTest.cpp
+++ b/test/IXTest.cpp
@ -170,58 +170,4 @@ namespace ix

        std::cout << prefix << ": " << s << " => " << ss.str() << std::endl;
    }
-
-    bool startWebSocketEchoServer(ix::WebSocketServer& server)
-    {
-        server.setOnConnectionCallback(
-            [&server](std::shared_ptr<ix::WebSocket> webSocket,
-                      std::shared_ptr<ConnectionState> connectionState)
-            {
-                webSocket->setOnMessageCallback(
-                    [webSocket, connectionState, &server](ix::WebSocketMessageType messageType,
-                       const std::string& str,
-                       size_t wireSize,
-                       const ix::WebSocketErrorInfo& error,
-                       const ix::WebSocketOpenInfo& openInfo,
-                       const ix::WebSocketCloseInfo& closeInfo)
-                    {
-                        if (messageType == ix::WebSocketMessageType::Open)
-                        {
-                            Logger() << "New connection";
-                            Logger() << "Uri: " << openInfo.uri;
-                            Logger() << "Headers:";
-                            for (auto it : openInfo.headers)
-                            {
-                                Logger() << it.first << ": " << it.second;
-                            }
-                        }
-                        else if (messageType == ix::WebSocketMessageType::Close)
-                        {
-                            Logger() << "Closed connection";
-                        }
-                        else if (messageType == ix::WebSocketMessageType::Message)
-                        {
-                            for (auto&& client : server.getClients())
-                            {
-                                if (client != webSocket)
-                                {
-                                    client->send(str);
-                                }
-                            }
-                        }
-                    }
-                );
-            }
-        );
-
-        auto res = server.listen();
-        if (!res.first)
-        {
-            Logger() << res.second;
-            return false;
-        }
-
-        server.start();
-        return true;
-    }
 }
--- a/test/IXTest.h
+++ b/test/IXTest.h
@ -11,8 +11,6 @@
 #include <sstream>
 #include <iostream>
 #include <mutex>
-#include <spdlog/spdlog.h>
-#include <ixwebsocket/IXWebSocketServer.h>

 namespace ix
 {
@ -34,9 +32,8 @@ namespace ix
            {
                std::lock_guard<std::mutex> lock(_mutex);

-                std::stringstream ss;
-                ss << obj;
-                spdlog::info(ss.str());
+                std::cerr << obj;
+                std::cerr << std::endl;
                return *this;
            }

@ -47,6 +44,4 @@ namespace ix
    void log(const std::string& msg);

    int getFreePort();
-
-    bool startWebSocketEchoServer(ix::WebSocketServer& server);
 }
--- a/test/IXWebSocketCloseTest.cpp
+++ b/test/IXWebSocketCloseTest.cpp
@ -61,7 +61,7 @@ namespace
    uint16_t WebSocketClient::getCloseCode()
    {
        std::lock_guard<std::mutex> lck(_mutexCloseData);
-
+        
        return _closeCode;
    }

@ -75,7 +75,7 @@ namespace
    bool WebSocketClient::getCloseRemote()
    {
        std::lock_guard<std::mutex> lck(_mutexCloseData);
-
+        
        return _closeRemote;
    }

@ -86,7 +86,8 @@ namespace

    void WebSocketClient::stop(uint16_t code, const std::string& reason)
    {
-        _webSocket.stop(code, reason);
+        _webSocket.close(code, reason);
+        _webSocket.stop();
    }

    void WebSocketClient::start()
@ -126,11 +127,11 @@ namespace
                    log("client disconnected");

                    std::lock_guard<std::mutex> lck(_mutexCloseData);
-
+                    
                    _closeCode = closeInfo.code;
                    _closeReason = std::string(closeInfo.reason);
                    _closeRemote = closeInfo.remote;
-
+                    
                    _webSocket.disableAutomaticReconnection();
                }
                else if (messageType == ix::WebSocketMessageType::Error)
@ -209,7 +210,7 @@ namespace
                            //Logger() << closeInfo.remote;

                            std::lock_guard<std::mutex> lck(mutexWrite);
-
+                            
                            receivedCloseCode = closeInfo.code;
                            receivedCloseReason = std::string(closeInfo.reason);
                            receivedCloseRemote = closeInfo.remote;
@ -239,7 +240,7 @@ TEST_CASE("Websocket_client_close_default", "[close]")

        int port = getFreePort();
        ix::WebSocketServer server(port);
-
+        
        uint16_t serverReceivedCloseCode(0);
        bool serverReceivedCloseRemote(false);
        std::string serverReceivedCloseReason("");
@ -274,7 +275,7 @@ TEST_CASE("Websocket_client_close_default", "[close]")

        {
            std::lock_guard<std::mutex> lck(mutexWrite);
-
+            
            // Here we read the code/reason received by the server, and ensure that remote is true
            REQUIRE(serverReceivedCloseCode == 1000);
            REQUIRE(serverReceivedCloseReason == "Normal closure");
@ -297,7 +298,7 @@ TEST_CASE("Websocket_client_close_params_given", "[close]")

        int port = getFreePort();
        ix::WebSocketServer server(port);
-
+        
        uint16_t serverReceivedCloseCode(0);
        bool serverReceivedCloseRemote(false);
        std::string serverReceivedCloseReason("");
@ -332,7 +333,7 @@ TEST_CASE("Websocket_client_close_params_given", "[close]")

        {
            std::lock_guard<std::mutex> lck(mutexWrite);
-
+            
            // Here we read the code/reason received by the server, and ensure that remote is true
            REQUIRE(serverReceivedCloseCode == 4000);
            REQUIRE(serverReceivedCloseReason == "My reason");
@ -355,7 +356,7 @@ TEST_CASE("Websocket_server_close", "[close]")

        int port = getFreePort();
        ix::WebSocketServer server(port);
-
+        
        uint16_t serverReceivedCloseCode(0);
        bool serverReceivedCloseRemote(false);
        std::string serverReceivedCloseReason("");
@ -390,7 +391,7 @@ TEST_CASE("Websocket_server_close", "[close]")

        {
            std::lock_guard<std::mutex> lck(mutexWrite);
-
+            
            // Here we read the code/reason received by the server, and ensure that remote is true
            REQUIRE(serverReceivedCloseCode == 1000);
            REQUIRE(serverReceivedCloseReason == "Normal closure");
--- a/test/IXWebSocketPingTimeoutTest.cpp
+++ b/test/IXWebSocketPingTimeoutTest.cpp
@ -359,13 +359,12 @@ TEST_CASE("Websocket_no_ping_but_timeout", "[setPingTimeout]")
        REQUIRE(webSocketClient.isClosed() == false);
        REQUIRE(webSocketClient.closedDueToPingTimeout() == false);

-        ix::msleep(300);
+        ix::msleep(200);

        // Here we test ping timeout, timeout
        REQUIRE(serverReceivedPingMessages == 0);
        REQUIRE(webSocketClient.getReceivedPongMessages() == 0);
-        // Ensure client close was by ping timeout
-        ix::msleep(300);
+        // Ensure client close was not by ping timeout
        REQUIRE(webSocketClient.isClosed() == true);
        REQUIRE(webSocketClient.closedDueToPingTimeout() == true);

@ -416,8 +415,7 @@ TEST_CASE("Websocket_ping_timeout", "[setPingTimeout]")
        // Here we test ping timeout, timeout
        REQUIRE(serverReceivedPingMessages == 1);
        REQUIRE(webSocketClient.getReceivedPongMessages() == 0);
-        // Ensure client close was by ping timeout
-        ix::msleep(300);
+        // Ensure client close was not by ping timeout
        REQUIRE(webSocketClient.isClosed() == true);
        REQUIRE(webSocketClient.closedDueToPingTimeout() == true);

--- a/test/IXWebSocketTestConnectionDisconnection.cpp
+++ b/test/IXWebSocketTestConnectionDisconnection.cpp
@ -62,33 +62,33 @@ namespace
                std::stringstream ss;
                if (messageType == ix::WebSocketMessageType::Open)
                {
-                    log("TestConnectionDisconnection: connected !");
+                    log("cmd_websocket_satori_chat: connected !");
                }
                else if (messageType == ix::WebSocketMessageType::Close)
                {
-                    log("TestConnectionDisconnection: disconnected !");
+                    log("cmd_websocket_satori_chat: disconnected !");
                }
                else if (messageType == ix::WebSocketMessageType::Error)
                {
-                    ss << "TestConnectionDisconnection: Error! ";
+                    ss << "cmd_websocket_satori_chat: Error! ";
                    ss << error.reason;
                    log(ss.str());
                }
                else if (messageType == ix::WebSocketMessageType::Message)
                {
-                    log("TestConnectionDisconnection: received message.!");
+                    log("cmd_websocket_satori_chat: received message.!");
                }
                else if (messageType == ix::WebSocketMessageType::Ping)
                {
-                    log("TestConnectionDisconnection: received ping message.!");
+                    log("cmd_websocket_satori_chat: received ping message.!");
                }
                else if (messageType == ix::WebSocketMessageType::Pong)
                {
-                    log("TestConnectionDisconnection: received pong message.!");
+                    log("cmd_websocket_satori_chat: received pong message.!");
                }
                else if (messageType == ix::WebSocketMessageType::Fragment)
                {
-                    log("TestConnectionDisconnection: received fragment.!");
+                    log("cmd_websocket_satori_chat: received fragment.!");
                }
                else
                {
@ -96,12 +96,6 @@ namespace
                }
            });

-        _webSocket.enableAutomaticReconnection();
-        REQUIRE(_webSocket.isAutomaticReconnectionEnabled() == true);
-
-        _webSocket.disableAutomaticReconnection();
-        REQUIRE(_webSocket.isAutomaticReconnectionEnabled() == false);
-
        // Start the connection
        _webSocket.start();
    }
@ -129,38 +123,26 @@ TEST_CASE("websocket_connections", "[websocket]")
    SECTION("Try to connect and disconnect with different timing, not enough time to succesfully connect")
    {
        IXWebSocketTestConnectionDisconnection test;
-        log(std::string("50 Runs"));
-
        for (int i = 0; i < 50; ++i)
        {
            log(std::string("Run: ") + std::to_string(i));
            test.start(WEBSOCKET_DOT_ORG_URL);
-
-            log(std::string("Sleeping"));
            ix::msleep(i);
-
-            log(std::string("Stopping"));
            test.stop();
        }
    }

    // This test breaks on travis CI - Ubuntu Xenial + gcc + tsan
    // We should fix this.
-    SECTION("Try to connect and disconnect with different timing, from not enough time to successfull connect")
+    /*SECTION("Try to connect and disconnect with different timing, from not enough time to successfull connect")
    {
        IXWebSocketTestConnectionDisconnection test;
-        log(std::string("20 Runs"));
-
        for (int i = 0; i < 20; ++i)
        {
            log(std::string("Run: ") + std::to_string(i));
            test.start(WEBSOCKET_DOT_ORG_URL);
-
-            log(std::string("Sleeping"));
            ix::msleep(i*50);
-
-            log(std::string("Stopping"));
            test.stop();
        }
-    }
+    }*/
 }
--- a/test/run.py
+++ b/test/run.py
@ -1,4 +1,10 @@
 #!/usr/bin/env python2.7
+'''
+Windows notes:
+    generator = '-G"NMake Makefiles"'
+    make = 'nmake'
+    testBinary ='ixwebsocket_unittest.exe'
+'''

 from __future__ import print_function

@ -97,8 +103,7 @@ def runCMake(sanitizer, buildDir):

    if platform.system() == 'Windows':
        #generator = '"NMake Makefiles"'
-        #generator = '"Visual Studio 16 2019"'
-        generator = '"Visual Studio 15 2017"'
+        generator = '"Visual Studio 16 2019"'
    else:
        generator = '"Unix Makefiles"'

@ -269,12 +274,12 @@ def executeJob(job):
    return job


-def executeJobs(jobs, cpuCount):
+def executeJobs(jobs):
    '''Execute a list of job concurrently on multiple CPU/cores'''

-    print('Using {} cores to execute the unittest'.format(cpuCount))
+    poolSize = multiprocessing.cpu_count()

-    pool = multiprocessing.Pool(cpuCount)
+    pool = multiprocessing.Pool(poolSize)
    results = pool.map(executeJob, jobs)
    pool.close()
    pool.join()
@ -346,22 +351,26 @@ def generateXmlOutput(results, xmlOutput, testRunName, runTime):
        f.write(content.encode('utf-8'))


-def run(testName, buildDir, sanitizer, xmlOutput,
-        testRunName, buildOnly, useLLDB, cpuCount):
+def run(testName, buildDir, sanitizer, xmlOutput, testRunName, buildOnly, useLLDB):
    '''Main driver. Run cmake, compiles, execute and validate the testsuite.'''

    # gen build files with CMake
    runCMake(sanitizer, buildDir)

-    if platform.system() == 'Linux':
-        # build with make -j
-        runCommand('make -C {} -j 2'.format(buildDir))
-    elif platform.system() == 'Darwin':
-        # build with make
-        runCommand('make -C {} -j 8'.format(buildDir))
-    else:
-        # build with cmake on recent
-        runCommand('cmake --build --parallel {}'.format(buildDir))
+    # build with make
+    #makeCmd = 'cmake --build '
+    #jobs = '-j8'
+
+    #if platform.system() == 'Windows':
+    #    makeCmd = 'nmake'
+
+        # nmake does not have a -j option
+    #    jobs = ''
+
+    #runCommand('{} -C {} {}'.format(makeCmd, buildDir, jobs))
+
+    # build with cmake
+    runCommand('cmake --build ' + buildDir)

    if buildOnly:
        return
@ -406,7 +415,7 @@ def run(testName, buildDir, sanitizer, xmlOutput,
        })

    start = time.time()
-    results = executeJobs(jobs, cpuCount)
+    results = executeJobs(jobs)
    runTime = time.time() - start
    generateXmlOutput(results, xmlOutput, testRunName, runTime)

@ -456,8 +465,6 @@ def main():
                        help='Run the test through lldb.')
    parser.add_argument('--run_name', '-n',
                        help='Name of the test run.')
-    parser.add_argument('--cpu_count', '-j', type=int, default=multiprocessing.cpu_count(),
-                        help='Number of cpus to use for running the tests.')

    args = parser.parse_args()

@ -503,7 +510,7 @@ def main():
        args.lldb = False

    return run(args.test, buildDir, sanitizer, xmlOutput, 
-               testRunName, args.build_only, args.lldb, args.cpu_count)
+               testRunName, args.build_only, args.lldb)


 if __name__ == '__main__':
--- a/third_party/spdlog/README.md
+++ b/third_party/spdlog/README.md
@ -1,319 +1,319 @@
-# spdlog
-
-Very fast, header only, C++ logging library. [![Build Status](https://travis-ci.org/gabime/spdlog.svg?branch=master)](https://travis-ci.org/gabime/spdlog)&nbsp; [![Build status](https://ci.appveyor.com/api/projects/status/d2jnxclg20vd0o50?svg=true)](https://ci.appveyor.com/project/gabime/spdlog)
-
-
-
-## Install
-#### Just copy the headers:
-
-* Copy the source [folder](https://github.com/gabime/spdlog/tree/v1.x/include/spdlog) to your build tree and use a C++11 compiler.
-
-#### Or use your favorite package manager:
-
-* Ubuntu: `apt-get install libspdlog-dev`
-* Homebrew: `brew install spdlog`
-* FreeBSD:  `cd /usr/ports/devel/spdlog/ && make install clean`
-* Fedora: `yum install spdlog`
-* Gentoo: `emerge dev-libs/spdlog`
-* Arch Linux: `yaourt -S spdlog-git`
-* vcpkg: `vcpkg install spdlog`
-
-
-## Platforms
- * Linux, FreeBSD, OpenBSD, Solaris, AIX
- * Windows (msvc 2013+, cygwin)
- * macOS (clang 3.5+)
- * Android
-
-## Features
-* Very fast (see [benchmarks](#benchmarks) below).
-* Headers only, just copy and use.
-* Feature rich formatting, using the excellent [fmt](https://github.com/fmtlib/fmt) library.
-* Fast asynchronous mode (optional)
-* [Custom](https://github.com/gabime/spdlog/wiki/3.-Custom-formatting) formatting.
-* Multi/Single threaded loggers.
-* Various log targets:
-    * Rotating log files.
-    * Daily log files.
-    * Console logging (colors supported).
-    * syslog.
-    * Windows debugger (```OutputDebugString(..)```)
-    * Easily extendable with custom log targets  (just implement a single function in the [sink](include/spdlog/sinks/sink.h) interface).
-* Severity based filtering - threshold levels can be modified in runtime as well as in compile time.
-* Binary data logging.
-
-
-## Benchmarks
-
-Below are some [benchmarks](https://github.com/gabime/spdlog/blob/v1.x/bench/bench.cpp) done in Ubuntu 64 bit, Intel i7-4770 CPU @ 3.40GHz
-
-#### Synchronous mode
-```
-*******************************************************************************
-Single thread, 1,000,000 iterations
-*******************************************************************************
-basic_st...             Elapsed: 0.181652       5,505,042/sec
-rotating_st...          Elapsed: 0.181781       5,501,117/sec
-daily_st...             Elapsed: 0.187595       5,330,630/sec
-null_st...              Elapsed: 0.0504704      19,813,602/sec
-*******************************************************************************
-10 threads sharing same logger, 1,000,000 iterations
-*******************************************************************************
-basic_mt...             Elapsed: 0.616035       1,623,284/sec
-rotating_mt...          Elapsed: 0.620344       1,612,008/sec
-daily_mt...             Elapsed: 0.648353       1,542,369/sec
-null_mt...              Elapsed: 0.151972       6,580,166/sec
-```
-#### Asynchronous mode
-```
-*******************************************************************************
-10 threads sharing same logger, 1,000,000 iterations
-*******************************************************************************
-async...                Elapsed: 0.350066       2,856,606/sec
-async...                Elapsed: 0.314865       3,175,960/sec
-async...                Elapsed: 0.349851       2,858,358/sec
-```
-
-## Usage samples
-
-#### Basic usage
-```c++
-#include "spdlog/spdlog.h"
-int main()
-{
-    spdlog::info("Welcome to spdlog!");
-    spdlog::error("Some error message with arg: {}", 1);
-
-    spdlog::warn("Easy padding in numbers like {:08d}", 12);
-    spdlog::critical("Support for int: {0:d};  hex: {0:x};  oct: {0:o}; bin: {0:b}", 42);
-    spdlog::info("Support for floats {:03.2f}", 1.23456);
-    spdlog::info("Positional args are {1} {0}..", "too", "supported");
-    spdlog::info("{:<30}", "left aligned");
-
-    spdlog::set_level(spdlog::level::debug); // Set global log level to debug
-    spdlog::debug("This message should be displayed..");
-
-    // change log pattern
-    spdlog::set_pattern("[%H:%M:%S %z] [%n] [%^---%L---%$] [thread %t] %v");
-
-    // Compile time log levels
-    // define SPDLOG_ACTIVE_LEVEL to desired level
-    SPDLOG_TRACE("Some trace message with param {}", {});
-    SPDLOG_DEBUG("Some debug message");
-
-}
-```
-#### create stdout/stderr logger object
-```c++
-#include "spdlog/spdlog.h"
-#include "spdlog/sinks/stdout_color_sinks.h"
-void stdout_example()
-{
-    // create color multi threaded logger
-    auto console = spdlog::stdout_color_mt("console");
-    auto err_logger = spdlog::stderr_color_mt("stderr");
-    spdlog::get("console")->info("loggers can be retrieved from a global registry using the spdlog::get(logger_name)");
-}
-```
---
-#### Basic file logger
-```c++
-#include "spdlog/sinks/basic_file_sink.h"
-void basic_logfile_example()
-{
-    try
-    {
-        auto my_logger = spdlog::basic_logger_mt("basic_logger", "logs/basic-log.txt");
-    }
-    catch (const spdlog::spdlog_ex &ex)
-    {
-        std::cout << "Log init failed: " << ex.what() << std::endl;
-    }
-}
-```
---
-#### Rotating files
-```c++
-#include "spdlog/sinks/rotating_file_sink.h"
-void rotating_example()
-{
-    // Create a file rotating logger with 5mb size max and 3 rotated files
-    auto rotating_logger = spdlog::rotating_logger_mt("some_logger_name", "logs/rotating.txt", 1048576 * 5, 3);
-}
-```
-
---
-#### Daily files
-```c++
-
-#include "spdlog/sinks/daily_file_sink.h"
-void daily_example()
-{
-    // Create a daily logger - a new file is created every day on 2:30am
-    auto daily_logger = spdlog::daily_logger_mt("daily_logger", "logs/daily.txt", 2, 30);
-}
-
-```
-
---
-#### Cloning loggers
-```c++
-// clone a logger and give it new name.
-// Useful for creating subsystem loggers from some "root" logger
-void clone_example()
-{
-    auto network_logger = spdlog::get("root")->clone("network");
-    network_logger->info("Logging network stuff..");
-}
-```
-
---
-#### Periodic flush
-```c++
-// periodically flush all *registered* loggers every 3 seconds:
-// warning: only use if all your loggers are thread safe!
-spdlog::flush_every(std::chrono::seconds(3));
-
-```
-
---
-#### Binary logging
-```c++
-// log binary data as hex.
-// many types of std::container<char> types can be used.
-// ranges are supported too.
-// format flags:
-// {:X} - print in uppercase.
-// {:s} - don't separate each byte with space.
-// {:p} - don't print the position on each line start.
-// {:n} - don't split the output to lines.
-
-#include "spdlog/fmt/bin_to_hex.h"
-
-void binary_example()
-{
-    auto console = spdlog::get("console");
-    std::array<char, 80> buf;
-    console->info("Binary example: {}", spdlog::to_hex(buf));
-    console->info("Another binary example:{:n}", spdlog::to_hex(std::begin(buf), std::begin(buf) + 10));
-    // more examples:
-    // logger->info("uppercase: {:X}", spdlog::to_hex(buf));
-    // logger->info("uppercase, no delimiters: {:Xs}", spdlog::to_hex(buf));
-    // logger->info("uppercase, no delimiters, no position info: {:Xsp}", spdlog::to_hex(buf));
-}
-
-```
-
---
-#### Logger with multi sinks - each with different format and log level
-```c++
-
-// create logger with 2 targets with different log levels and formats.
-// the console will show only warnings or errors, while the file will log all.
-void multi_sink_example()
-{
-    auto console_sink = std::make_shared<spdlog::sinks::stdout_color_sink_mt>();
-    console_sink->set_level(spdlog::level::warn);
-    console_sink->set_pattern("[multi_sink_example] [%^%l%$] %v");
-
-    auto file_sink = std::make_shared<spdlog::sinks::basic_file_sink_mt>("logs/multisink.txt", true);
-    file_sink->set_level(spdlog::level::trace);
-
-    spdlog::logger logger("multi_sink", {console_sink, file_sink});
-    logger.set_level(spdlog::level::debug);
-    logger.warn("this should appear in both console and file");
-    logger.info("this message should not appear in the console, only in the file");
-}
-```
-
---
-#### Asynchronous logging
-```c++
-#include "spdlog/async.h"
-#include "spdlog/sinks/basic_file_sink.h"
-void async_example()
-{
-    // default thread pool settings can be modified *before* creating the async logger:
-    // spdlog::init_thread_pool(8192, 1); // queue with 8k items and 1 backing thread.
-    auto async_file = spdlog::basic_logger_mt<spdlog::async_factory>("async_file_logger", "logs/async_log.txt");
-    // alternatively:
-    // auto async_file = spdlog::create_async<spdlog::sinks::basic_file_sink_mt>("async_file_logger", "logs/async_log.txt");
-}
-
-```
-
---
-#### Asynchronous logger with multi sinks
-```c++
-#include "spdlog/sinks/stdout_color_sinks.h"
-#include "spdlog/sinks/rotating_file_sink.h"
-
-void multi_sink_example2()
-{
-    spdlog::init_thread_pool(8192, 1);
-    auto stdout_sink = std::make_shared<spdlog::sinks::stdout_color_sink_mt >();
-    auto rotating_sink = std::make_shared<spdlog::sinks::rotating_file_sink_mt>("mylog.txt", 1024*1024*10, 3);
-    std::vector<spdlog::sink_ptr> sinks {stdout_sink, rotating_sink};
-    auto logger = std::make_shared<spdlog::async_logger>("loggername", sinks.begin(), sinks.end(), spdlog::thread_pool(), spdlog::async_overflow_policy::block);
-    spdlog::register_logger(logger);
-}
-```
-
---
-#### User defined types
-```c++
-// user defined types logging by implementing operator<<
-#include "spdlog/fmt/ostr.h" // must be included
-struct my_type
-{
-    int i;
-    template<typename OStream>
-    friend OStream &operator<<(OStream &os, const my_type &c)
-    {
-        return os << "[my_type i=" << c.i << "]";
-    }
-};
-
-void user_defined_example()
-{
-    spdlog::get("console")->info("user defined type: {}", my_type{14});
-}
-
-```
---
-#### Custom error handler
-```c++
-void err_handler_example()
-{
-    // can be set globally or per logger(logger->set_error_handler(..))
-    spdlog::set_error_handler([](const std::string &msg) { spdlog::get("console")->error("*** LOGGER ERROR ***: {}", msg); });
-    spdlog::get("console")->info("some invalid message to trigger an error {}{}{}{}", 3);
-}
-
-```
---
-#### syslog
-```c++
-#include "spdlog/sinks/syslog_sink.h"
-void syslog_example()
-{
-    std::string ident = "spdlog-example";
-    auto syslog_logger = spdlog::syslog_logger_mt("syslog", ident, LOG_PID);
-    syslog_logger->warn("This is warning that will end up in syslog.");
-}
-```
---
-#### Android example
-```c++
-#include "spdlog/sinks/android_sink.h"
-void android_example()
-{
-    std::string tag = "spdlog-android";
-    auto android_logger = spdlog::android_logger("android", tag);
-    android_logger->critical("Use \"adb shell logcat\" to view this message.");
-}
-```
-
-## Documentation
-Documentation can be found in the [wiki](https://github.com/gabime/spdlog/wiki/1.-QuickStart) pages.
+# spdlog
+
+Very fast, header only, C++ logging library. [![Build Status](https://travis-ci.org/gabime/spdlog.svg?branch=master)](https://travis-ci.org/gabime/spdlog)&nbsp; [![Build status](https://ci.appveyor.com/api/projects/status/d2jnxclg20vd0o50?svg=true)](https://ci.appveyor.com/project/gabime/spdlog)
+
+
+
+## Install
+#### Just copy the headers:
+
+* Copy the source [folder](https://github.com/gabime/spdlog/tree/v1.x/include/spdlog) to your build tree and use a C++11 compiler.
+
+#### Or use your favorite package manager:
+
+* Ubuntu: `apt-get install libspdlog-dev`
+* Homebrew: `brew install spdlog`
+* FreeBSD:  `cd /usr/ports/devel/spdlog/ && make install clean`
+* Fedora: `yum install spdlog`
+* Gentoo: `emerge dev-libs/spdlog`
+* Arch Linux: `yaourt -S spdlog-git`
+* vcpkg: `vcpkg install spdlog`
+ 
+
+## Platforms
+ * Linux, FreeBSD, OpenBSD, Solaris, AIX
+ * Windows (msvc 2013+, cygwin)
+ * macOS (clang 3.5+)
+ * Android
+
+## Features
+* Very fast (see [benchmarks](#benchmarks) below).
+* Headers only, just copy and use.
+* Feature rich formatting, using the excellent [fmt](https://github.com/fmtlib/fmt) library.
+* Fast asynchronous mode (optional)
+* [Custom](https://github.com/gabime/spdlog/wiki/3.-Custom-formatting) formatting.
+* Multi/Single threaded loggers.
+* Various log targets:
+    * Rotating log files.
+    * Daily log files.
+    * Console logging (colors supported).
+    * syslog.
+    * Windows debugger (```OutputDebugString(..)```)
+    * Easily extendable with custom log targets  (just implement a single function in the [sink](include/spdlog/sinks/sink.h) interface).
+* Severity based filtering - threshold levels can be modified in runtime as well as in compile time.
+* Binary data logging.
+
+
+## Benchmarks
+
+Below are some [benchmarks](https://github.com/gabime/spdlog/blob/v1.x/bench/bench.cpp) done in Ubuntu 64 bit, Intel i7-4770 CPU @ 3.40GHz
+
+#### Synchronous mode
+```
+*******************************************************************************
+Single thread, 1,000,000 iterations
+*******************************************************************************
+basic_st...             Elapsed: 0.181652       5,505,042/sec
+rotating_st...          Elapsed: 0.181781       5,501,117/sec
+daily_st...             Elapsed: 0.187595       5,330,630/sec
+null_st...              Elapsed: 0.0504704      19,813,602/sec
+*******************************************************************************
+10 threads sharing same logger, 1,000,000 iterations
+*******************************************************************************
+basic_mt...             Elapsed: 0.616035       1,623,284/sec
+rotating_mt...          Elapsed: 0.620344       1,612,008/sec
+daily_mt...             Elapsed: 0.648353       1,542,369/sec
+null_mt...              Elapsed: 0.151972       6,580,166/sec
+``` 
+#### Asynchronous mode
+```
+*******************************************************************************
+10 threads sharing same logger, 1,000,000 iterations 
+*******************************************************************************
+async...                Elapsed: 0.350066       2,856,606/sec
+async...                Elapsed: 0.314865       3,175,960/sec
+async...                Elapsed: 0.349851       2,858,358/sec
+```
+
+## Usage samples
+
+#### Basic usage
+```c++
+#include "spdlog/spdlog.h"
+int main() 
+{
+    spdlog::info("Welcome to spdlog!");
+    spdlog::error("Some error message with arg: {}", 1);
+    
+    spdlog::warn("Easy padding in numbers like {:08d}", 12);
+    spdlog::critical("Support for int: {0:d};  hex: {0:x};  oct: {0:o}; bin: {0:b}", 42);
+    spdlog::info("Support for floats {:03.2f}", 1.23456);
+    spdlog::info("Positional args are {1} {0}..", "too", "supported");
+    spdlog::info("{:<30}", "left aligned");
+    
+    spdlog::set_level(spdlog::level::debug); // Set global log level to debug
+    spdlog::debug("This message should be displayed..");    
+    
+    // change log pattern
+    spdlog::set_pattern("[%H:%M:%S %z] [%n] [%^---%L---%$] [thread %t] %v");
+    
+    // Compile time log levels
+    // define SPDLOG_ACTIVE_LEVEL to desired level
+    SPDLOG_TRACE("Some trace message with param {}", {});
+    SPDLOG_DEBUG("Some debug message");
+        
+}
+```
+#### create stdout/stderr logger object
+```c++
+#include "spdlog/spdlog.h"
+#include "spdlog/sinks/stdout_color_sinks.h"
+void stdout_example()
+{
+    // create color multi threaded logger
+    auto console = spdlog::stdout_color_mt("console");    
+    auto err_logger = spdlog::stderr_color_mt("stderr");    
+    spdlog::get("console")->info("loggers can be retrieved from a global registry using the spdlog::get(logger_name)");
+}
+```
+---
+#### Basic file logger
+```c++
+#include "spdlog/sinks/basic_file_sink.h"
+void basic_logfile_example()
+{
+    try 
+    {
+        auto my_logger = spdlog::basic_logger_mt("basic_logger", "logs/basic-log.txt");
+    }
+    catch (const spdlog::spdlog_ex &ex)
+    {
+        std::cout << "Log init failed: " << ex.what() << std::endl;
+    }
+}
+```
+---
+#### Rotating files
+```c++
+#include "spdlog/sinks/rotating_file_sink.h"
+void rotating_example()
+{
+    // Create a file rotating logger with 5mb size max and 3 rotated files
+    auto rotating_logger = spdlog::rotating_logger_mt("some_logger_name", "logs/rotating.txt", 1048576 * 5, 3);
+}
+```
+
+---
+#### Daily files
+```c++
+
+#include "spdlog/sinks/daily_file_sink.h"
+void daily_example()
+{
+    // Create a daily logger - a new file is created every day on 2:30am
+    auto daily_logger = spdlog::daily_logger_mt("daily_logger", "logs/daily.txt", 2, 30);
+}
+
+```
+
+---
+#### Cloning loggers 
+```c++
+// clone a logger and give it new name.
+// Useful for creating subsystem loggers from some "root" logger
+void clone_example()
+{
+    auto network_logger = spdlog::get("root")->clone("network");
+    network_logger->info("Logging network stuff..");
+}
+```
+
+---
+#### Periodic flush
+```c++
+// periodically flush all *registered* loggers every 3 seconds:
+// warning: only use if all your loggers are thread safe!
+spdlog::flush_every(std::chrono::seconds(3));
+
+```
+
+---
+#### Binary logging
+```c++
+// log binary data as hex.
+// many types of std::container<char> types can be used.
+// ranges are supported too.
+// format flags:
+// {:X} - print in uppercase.
+// {:s} - don't separate each byte with space.
+// {:p} - don't print the position on each line start.
+// {:n} - don't split the output to lines.
+
+#include "spdlog/fmt/bin_to_hex.h"
+
+void binary_example()
+{
+    auto console = spdlog::get("console");
+    std::array<char, 80> buf;
+    console->info("Binary example: {}", spdlog::to_hex(buf));
+    console->info("Another binary example:{:n}", spdlog::to_hex(std::begin(buf), std::begin(buf) + 10));
+    // more examples:
+    // logger->info("uppercase: {:X}", spdlog::to_hex(buf));
+    // logger->info("uppercase, no delimiters: {:Xs}", spdlog::to_hex(buf));
+    // logger->info("uppercase, no delimiters, no position info: {:Xsp}", spdlog::to_hex(buf));
+}
+
+```
+
+---
+#### Logger with multi sinks - each with different format and log level
+```c++
+
+// create logger with 2 targets with different log levels and formats.
+// the console will show only warnings or errors, while the file will log all.
+void multi_sink_example()
+{
+    auto console_sink = std::make_shared<spdlog::sinks::stdout_color_sink_mt>();
+    console_sink->set_level(spdlog::level::warn);
+    console_sink->set_pattern("[multi_sink_example] [%^%l%$] %v");
+
+    auto file_sink = std::make_shared<spdlog::sinks::basic_file_sink_mt>("logs/multisink.txt", true);
+    file_sink->set_level(spdlog::level::trace);
+
+    spdlog::logger logger("multi_sink", {console_sink, file_sink});
+    logger.set_level(spdlog::level::debug);
+    logger.warn("this should appear in both console and file");
+    logger.info("this message should not appear in the console, only in the file");
+}
+```
+
+---
+#### Asynchronous logging
+```c++
+#include "spdlog/async.h"
+#include "spdlog/sinks/basic_file_sink.h"
+void async_example()
+{
+    // default thread pool settings can be modified *before* creating the async logger:
+    // spdlog::init_thread_pool(8192, 1); // queue with 8k items and 1 backing thread.
+    auto async_file = spdlog::basic_logger_mt<spdlog::async_factory>("async_file_logger", "logs/async_log.txt");
+    // alternatively:
+    // auto async_file = spdlog::create_async<spdlog::sinks::basic_file_sink_mt>("async_file_logger", "logs/async_log.txt");   
+}
+
+```
+
+---
+#### Asynchronous logger with multi sinks  
+```c++
+#include "spdlog/sinks/stdout_color_sinks.h"
+#include "spdlog/sinks/rotating_file_sink.h"
+
+void multi_sink_example2()
+{
+    spdlog::init_thread_pool(8192, 1);
+    auto stdout_sink = std::make_shared<spdlog::sinks::stdout_color_sink_mt >();
+    auto rotating_sink = std::make_shared<spdlog::sinks::rotating_file_sink_mt>("mylog.txt", 1024*1024*10, 3);
+    std::vector<spdlog::sink_ptr> sinks {stdout_sink, rotating_sink};
+    auto logger = std::make_shared<spdlog::async_logger>("loggername", sinks.begin(), sinks.end(), spdlog::thread_pool(), spdlog::async_overflow_policy::block);
+    spdlog::register_logger(logger);
+}
+```
+ 
+---
+#### User defined types
+```c++
+// user defined types logging by implementing operator<<
+#include "spdlog/fmt/ostr.h" // must be included
+struct my_type
+{
+    int i;
+    template<typename OStream>
+    friend OStream &operator<<(OStream &os, const my_type &c)
+    {
+        return os << "[my_type i=" << c.i << "]";
+    }
+};
+
+void user_defined_example()
+{
+    spdlog::get("console")->info("user defined type: {}", my_type{14});
+}
+
+```
+---
+#### Custom error handler
+```c++
+void err_handler_example()
+{
+    // can be set globally or per logger(logger->set_error_handler(..))
+    spdlog::set_error_handler([](const std::string &msg) { spdlog::get("console")->error("*** LOGGER ERROR ***: {}", msg); });
+    spdlog::get("console")->info("some invalid message to trigger an error {}{}{}{}", 3);
+}
+
+```
+---
+#### syslog 
+```c++
+#include "spdlog/sinks/syslog_sink.h"
+void syslog_example()
+{
+    std::string ident = "spdlog-example";
+    auto syslog_logger = spdlog::syslog_logger_mt("syslog", ident, LOG_PID);
+    syslog_logger->warn("This is warning that will end up in syslog.");
+}
+```
+---
+#### Android example 
+```c++
+#include "spdlog/sinks/android_sink.h"
+void android_example()
+{
+    std::string tag = "spdlog-android";
+    auto android_logger = spdlog::android_logger("android", tag);
+    android_logger->critical("Use \"adb shell logcat\" to view this message.");
+}
+```
+
+## Documentation
+Documentation can be found in the [wiki](https://github.com/gabime/spdlog/wiki/1.-QuickStart) pages.
--- a/third_party/spdlog/include/spdlog/fmt/bundled/printf.h
+++ b/third_party/spdlog/include/spdlog/fmt/bundled/printf.h
@ -713,7 +713,7 @@ typedef basic_format_args<wprintf_context> wprintf_args;
 /**
  \rst
  Constructs an `~fmt::format_arg_store` object that contains references to
-  arguments and can be implicitly converted to `~fmt::printf_args`.
+  arguments and can be implicitly converted to `~fmt::printf_args`. 
  \endrst
 */
 template<typename... Args>
@ -723,7 +723,7 @@ inline format_arg_store<printf_context, Args...>
 /**
  \rst
  Constructs an `~fmt::format_arg_store` object that contains references to
-  arguments and can be implicitly converted to `~fmt::wprintf_args`.
+  arguments and can be implicitly converted to `~fmt::wprintf_args`. 
  \endrst
 */
 template<typename... Args>
--- a/third_party/spdlog/include/spdlog/fmt/bundled/ranges.h
+++ b/third_party/spdlog/include/spdlog/fmt/bundled/ranges.h
@ -159,7 +159,7 @@ void for_each(index_sequence<Is...>, Tuple &&tup, F &&f) FMT_NOEXCEPT {
 }

 template <class T>
-FMT_CONSTEXPR make_index_sequence<std::tuple_size<T>::value>
+FMT_CONSTEXPR make_index_sequence<std::tuple_size<T>::value> 
 get_indexes(T const &) { return {}; }

 template <class Tuple, class F>
@ -169,14 +169,14 @@ void for_each(Tuple &&tup, F &&f) {
 }

 template<typename Arg>
-FMT_CONSTEXPR const char* format_str_quoted(bool add_space, const Arg&,
+FMT_CONSTEXPR const char* format_str_quoted(bool add_space, const Arg&, 
  typename std::enable_if<
    !is_like_std_string<typename std::decay<Arg>::type>::value>::type* = nullptr) {
  return add_space ? " {}" : "{}";
 }

 template<typename Arg>
-FMT_CONSTEXPR const char* format_str_quoted(bool add_space, const Arg&,
+FMT_CONSTEXPR const char* format_str_quoted(bool add_space, const Arg&, 
  typename std::enable_if<
    is_like_std_string<typename std::decay<Arg>::type>::value>::type* = nullptr) {
  return add_space ? " \"{}\"" : "\"{}\"";
@ -205,7 +205,7 @@ struct is_tuple_like {
 };

 template <typename TupleT, typename Char>
-struct formatter<TupleT, Char,
+struct formatter<TupleT, Char, 
    typename std::enable_if<fmt::is_tuple_like<TupleT>::value>::type> {
 private:
  // C++11 generic lambda for format()
--- a/third_party/spdlog/include/spdlog/tweakme.h
+++ b/third_party/spdlog/include/spdlog/tweakme.h
@ -142,4 +142,4 @@
 // Defaults to __FUNCTION__ (should work on all compilers) if not defined.
 //
 // #define SPDLOG_FUNCTION __PRETTY_FUNCTION__
-///////////////////////////////////////////////////////////////////////////////
+///////////////////////////////////////////////////////////////////////////////
--- a/third_party/spdlog/tests/main.cpp
+++ b/third_party/spdlog/tests/main.cpp
@ -1,2 +1,2 @@
 #define CATCH_CONFIG_MAIN
-#include "catch.hpp"
+#include "catch.hpp"
--- a/third_party/spdlog/tests/test_mpmc_q.cpp
+++ b/third_party/spdlog/tests/test_mpmc_q.cpp
@ -104,4 +104,4 @@ TEST_CASE("full_queue", "[mpmc_blocking_q]")
    int item = -1;
    q.dequeue_for(item, milliseconds(0));
    REQUIRE(item == 123456);
-}
+}
--- a/third_party/spdlog/tests/utils.h
+++ b/third_party/spdlog/tests/utils.h
@ -13,4 +13,4 @@ std::size_t count_lines(const std::string &filename);

 std::size_t get_filesize(const std::string &filename);

-bool ends_with(std::string const &value, std::string const &ending);
+bool ends_with(std::string const &value, std::string const &ending);
--- a/ws/test_ws.sh
+++ b/ws/test_ws.sh
@ -61,4 +61,4 @@ sleep 2
 kill `cat /tmp/ws_test/pidfile.transfer`
 kill `cat /tmp/ws_test/pidfile.receive`
 kill `cat /tmp/ws_test/pidfile.send`
-exit 0
+
Author	SHA1	Message	Date
Benjamin Sergeant	1ac02fdc0e	more tests disabled	2019-05-13 12:37:27 -07:00
Benjamin Sergeant	687956358d	disable IXWebSocketPingTimeoutTest	2019-05-13 12:26:40 -07:00
Benjamin Sergeant	1a42c92325	server code / add dedicated thread to close/join terminated connection threads	2019-05-13 12:20:03 -07:00
Benjamin Sergeant	6bb00b6788	close with params	2019-05-13 09:33:14 -07:00