check max frame size

CMakeLists.txt

@@ -107,7 +107,7 @@ elseif (WIN32)
     list( APPEND IXWEBSOCKET_SOURCES ixwebsocket/windows/IXSetThreadName_windows.cpp)
 elseif (${CMAKE_SYSTEM_NAME} MATCHES "FreeBSD")
     list( APPEND IXWEBSOCKET_SOURCES ixwebsocket/freebsd/IXSetThreadName_freebsd.cpp)
-else()
+elseif (${CMAKE_SYSTEM_NAME} MATCHES "Linux")
     list( APPEND IXWEBSOCKET_SOURCES ixwebsocket/linux/IXSetThreadName_linux.cpp)
     list( APPEND IXWEBSOCKET_SOURCES ixwebsocket/IXSelectInterruptEventFd.cpp)
     list( APPEND IXWEBSOCKET_HEADERS ixwebsocket/IXSelectInterruptEventFd.h)

DOCKER_VERSION

@@ -1 +1 @@
-7.3.4
+7.2.1

Dockerfile

@@ -19,7 +19,6 @@ RUN [ "make", "ws_install" ]
 FROM alpine as runtime
 
 RUN apk add --no-cache libstdc++
-RUN apk add --no-cache strace
 
 RUN addgroup -S app && adduser -S -G app app 
 COPY --chown=app:app --from=build /usr/local/bin/ws /usr/local/bin/ws

README.md

@@ -4,35 +4,7 @@
 
 IXWebSocket is a C++ library for WebSocket client and server development. It has minimal dependencies (no boost), is very simple to use and support everything you'll likely need for websocket dev (SSL, deflate compression, compiles on most platforms, etc...). HTTP client and server code is also available, but it hasn't received as much testing.
 
-It is been used on big mobile video game titles sending and receiving tons of messages since 2017 (iOS and Android). It was tested on macOS, iOS, Linux, Android, Windows and FreeBSD. Two important design goals are simplicity and correctness.
-
-```
-# Required on Windows
-ix::initNetSystem();
-
-# Our websocket object
-ix::WebSocket webSocket;
-
-std::string url("ws://localhost:8080/");
-webSocket.setUrl(url);
-
-// Setup a callback to be fired (in a background thread, watch out for race conditions !)
-// when a message or an event (open, close, error) is received
-webSocket.setOnMessageCallback([](const ix::WebSocketMessagePtr& msg)
-    {
-        if (msg->type == ix::WebSocketMessageType::Message)
-        {
-            std::cout << msg->str << std::endl;
-        }
-    }
-);
-
-// Now that our callback is setup, we can start our background thread and receive messages
-webSocket.start();
-
-// Send a message to the server (default to TEXT mode)
-webSocket.send("hello world");
-```
+It is been used on big mobile video game titles sending and receiving tons of messages since 2017 (iOS and Android).
 
 Interested ? Go read the [docs](https://machinezone.github.io/IXWebSocket/) ! If things don't work as expected, please create an issue in github, or even better a pull request if you know how to fix your problem.
 

docker-compose.yml

@@ -1,59 +1,43 @@
 version: "3"
 services:
-  # snake:
-  #   image: bsergean/ws:build
-  #   entrypoint: ws snake --port 8767 --host 0.0.0.0 --redis_hosts redis1
-  #   ports:
-  #     - "8767:8767"
-  #   networks:
-  #     - ws-net
-  #   depends_on:
-  #     - redis1
-
-  # proxy:
-  #   image: bsergean/ws:build
-  #   entrypoint: strace ws proxy_server --remote_host 'wss://cobra.addsrv.com' --host 0.0.0.0 --port 8765 -v
-  #   ports:
-  #     - "8765:8765"
-  #   networks:
-  #     - ws-net
-
-  pyproxy:
-    image: bsergean/ws_proxy:build
-    entrypoint: /usr/bin/ws_proxy.py --remote_url 'wss://cobra.addsrv.com' --host 0.0.0.0 --port 8765
+  snake:
+    image: bsergean/ws:build
+    entrypoint: ws snake --port 8765 --host 0.0.0.0 --redis_hosts redis1
     ports:
       - "8765:8765"
     networks:
       - ws-net
+    depends_on:
+      - redis1
 
-        #  ws:
-        #    security_opt:
-        #    - seccomp:unconfined
-        #    cap_add:
-        #    - SYS_PTRACE
-        #    stdin_open: true
-        #    tty: true
-        #    image: bsergean/ws:build
-        #    entrypoint: sh
-        #    networks:
-        #      - ws-net
-        #    depends_on:
-        #      - redis1
-        #
-        #  redis1:
-        #    image: redis:alpine
-        #    networks:
-        #      - ws-net
-        #
-        #  statsd:
-        #    image: jaconel/statsd
-        #    ports:
-        #      - "8125:8125"
-        #    environment:
-        #      - STATSD_DUMP_MSG=true
-        #      - GRAPHITE_HOST=127.0.0.1
-        #    networks:
-        #      - ws-net
+  ws:
+    security_opt:
+    - seccomp:unconfined
+    cap_add:
+    - SYS_PTRACE
+    stdin_open: true
+    tty: true
+    image: bsergean/ws:build
+    entrypoint: bash
+    networks:
+      - ws-net
+    depends_on:
+      - redis1
+
+  redis1:
+    image: redis:alpine
+    networks:
+      - ws-net
+
+  statsd:
+    image: jaconel/statsd
+    ports:
+      - "8125:8125"
+    environment:
+      - STATSD_DUMP_MSG=true
+      - GRAPHITE_HOST=127.0.0.1
+    networks:
+      - ws-net
 
 networks:
   ws-net:

docs/CHANGELOG.md

@@ -1,22 +1,6 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
-## [7.3.4] - 2019-11-20
-
-- 32-bits compile fix, courtesy of @fcojavmc
-
-## [7.3.1] - 2019-11-16
-
-- ws proxy_server / remote server close not forwarded to the client
-
-## [7.3.0] - 2019-11-15
-
-- New ws command: `ws proxy_server`.
-
-## [7.2.2] - 2019-11-01
-
-- Tag a release + minor reformating.
-
 ## [7.2.1] - 2019-10-26
 
 - Add unittest to IXSentryClient to lua backtrace parsing code

docs/index.md

@@ -9,7 +9,6 @@
 * Linux
 * Android
 * Windows
-* FreeBSD
 
 ## Example code
 
@@ -45,7 +44,3 @@ webSocket.send("hello world");
 There are 2 main reasons that explain why IXWebSocket got written. First, we needed a C++ cross-platform client library, which should have few dependencies. What looked like the most solid one, [websocketpp](https://github.com/zaphoyd/websocketpp) did depend on boost and this was not an option for us. Secondly, there were other available libraries with fewer dependencies (C ones), but they required calling an explicit poll routine periodically to know if a client had received data from a server, which was not elegant.
 
 We started by solving those 2 problems, then we added server websocket code, then an HTTP client, and finally a very simple HTTP server.
-
-## Contributing
-
-IXWebSocket is developed on [github](https://github.com/machinezone/IXWebSocket). We'd love to hear about how you use it ; opening up an issue in github is ok for that. If things don't work as expected, please create an issue in github, or even better a pull request if you know how to fix your problem.

docs/ws.md

@@ -195,15 +195,6 @@ Server: Python/3.7 websockets/8.0.2
 Upgrade: websocket
 ```
 
-## Websocket proxy
-
-```
-ws proxy_server --remote_host ws://127.0.0.1:9000 -v
-Listening on 127.0.0.1:8008
-```
-
-If you connect to ws://127.0.0.1:8008, the proxy will connect to ws://127.0.0.1:9000 and pass all traffic to this server.
-
 ## File transfer
 
 ```

ixsnake/ixsnake/IXSnakeConnectionState.h

@@ -20,7 +20,6 @@ namespace snake
         {
             return _nonce;
         }
-
         void setNonce(const std::string& nonce)
         {
             _nonce = nonce;

ixwebsocket/IXSocketFactory.cpp

@@ -31,7 +31,6 @@ namespace ix
                                          std::string& errorMsg,
                                          const SocketTLSOptions& tlsOptions)
     {
-        (void) tlsOptions;
         errorMsg.clear();
         std::shared_ptr<Socket> socket;
 

ixwebsocket/IXWebSocketTransport.cpp

@@ -543,7 +543,7 @@ namespace ix
             }
 
             // Prevent integer overflow in the next conditional
-            const uint64_t maxFrameSize(1ULL << 63);
+            const uint64_t maxFrameSize(1 << 63);
             if (ws.N > maxFrameSize)
             {
                 return;

ixwebsocket/IXWebSocketVersion.h

@@ -6,4 +6,4 @@
 
 #pragma once
 
-#define IX_WEBSOCKET_VERSION "7.3.4"
+#define IX_WEBSOCKET_VERSION "7.1.0"

makefile

@@ -57,7 +57,6 @@ docker:
 docker_push:
 	docker tag ${IMG} ${LATEST}
 	docker push ${LATEST}
-	docker push ${IMG}
 
 run:
 	docker run --cap-add sys_ptrace --entrypoint=sh -it bsergean/ws:build

test/IXSentryClientTest.cpp

@@ -8,9 +8,10 @@
 
 #include "catch.hpp"
 #include <iostream>
-#include <ixsentry/IXSentryClient.h>
 #include <string.h>
 
+#include <ixsentry/IXSentryClient.h>
+
 using namespace ix;
 
 namespace ix
@@ -20,9 +21,7 @@ namespace ix
         SECTION("Attempt to index nil")
         {
             SentryClient sentryClient("");
-            std::string stack = "Attempt to index nil[overlay]!\nstack traceback:\n\tfoo.lua:2661: "
-                                "in function 'getFoo'\n\tfoo.lua:1666: in function "
-                                "'onUpdate'\n\tfoo.lua:1751: in function <foo.lua:1728>";
+            std::string stack = "Attempt to index nil[overlay]!\nstack traceback:\n\tfoo.lua:2661: in function 'getFoo'\n\tfoo.lua:1666: in function 'onUpdate'\n\tfoo.lua:1751: in function <foo.lua:1728>";
             auto frames = sentryClient.parseLuaStackTrace(stack);
 
             REQUIRE(frames.size() == 3);
@@ -31,8 +30,7 @@ namespace ix
         SECTION("Attempt to perform nil")
         {
             SentryClient sentryClient("");
-            std::string stack = "Attempt to perform nil - 1572111278.299\nstack "
-                                "traceback:\n\tfoo.lua:57: in function <foo.lua:53>";
+            std::string stack = "Attempt to perform nil - 1572111278.299\nstack traceback:\n\tfoo.lua:57: in function <foo.lua:53>";
             auto frames = sentryClient.parseLuaStackTrace(stack);
 
             REQUIRE(frames.size() == 1);

test/compatibility/python/websockets/DOCKER_VERSION

@@ -1 +0,0 @@
-0.0.1

test/compatibility/python/websockets/Dockerfile

@@ -1,8 +0,0 @@
-FROM python:3.8.0-alpine3.10
-
-RUN pip install websockets
-COPY ws_proxy.py /usr/bin
-RUN chmod +x /usr/bin/ws_proxy.py
-
-EXPOSE 8765
-CMD ["python", "/usr/bin/ws_proxy.py"]

test/compatibility/python/websockets/makefile

@@ -1,20 +0,0 @@
-.PHONY: docker
-
-NAME   := bsergean/ws_proxy
-TAG    := $(shell cat DOCKER_VERSION)
-IMG    := ${NAME}:${TAG}
-LATEST := ${NAME}:latest
-BUILD  := ${NAME}:build
-
-docker_test:
-	docker build -t ${BUILD} .
-
-docker:
-	git clean -dfx
-	docker build -t ${IMG} .
-	docker tag ${IMG} ${BUILD}
-
-docker_push:
-	docker tag ${IMG} ${LATEST}
-	docker push ${LATEST}
-	docker push ${IMG}

test/compatibility/python/websockets/ws_proxy.py

@@ -1,47 +0,0 @@
-#!/usr/bin/env python3
-
-# websocket proxy
-
-import argparse
-import asyncio
-import websockets
-
-
-async def hello(websocket, path):
-    '''Called whenever a new connection is made to the server'''
-
-    url = REMOTE_URL + path
-    async with websockets.connect(url) as ws:
-        taskA = asyncio.create_task(clientToServer(ws, websocket))
-        taskB = asyncio.create_task(serverToClient(ws, websocket))
-
-        await taskA
-        await taskB
-
-
-async def clientToServer(ws, websocket):
-    async for message in ws:
-        await websocket.send(message)
-
-
-async def serverToClient(ws, websocket):
-    async for message in websocket:
-        await ws.send(message)
-
-
-if __name__ == '__main__':
-    parser = argparse.ArgumentParser(description='websocket proxy.')
-    parser.add_argument('--host', help='Host to bind to.',
-                        default='localhost')
-    parser.add_argument('--port', help='Port to bind to.',
-                        default=8765)
-    parser.add_argument('--remote_url', help='Remote websocket url',
-                        default='ws://localhost:8767')
-    args = parser.parse_args()
-
-    REMOTE_URL = args.remote_url
-
-    start_server = websockets.serve(hello, args.host, args.port)
-
-    asyncio.get_event_loop().run_until_complete(start_server)
-    asyncio.get_event_loop().run_forever()

ws/CMakeLists.txt

@@ -55,7 +55,6 @@ add_executable(ws
   ws_cobra_metrics_to_redis.cpp
   ws_httpd.cpp
   ws_autobahn.cpp
-  ws_proxy_server.cpp
   ws.cpp)
 
 target_link_libraries(ws ixsnake)

ws/ws.cpp

@@ -72,7 +72,6 @@ int main(int argc, char** argv)
     std::string redisPassword;
     std::string appsConfigPath("appsConfig.json");
     std::string subprotocol;
-    std::string remoteHost;
     ix::SocketTLSOptions tlsOptions;
     std::string ciphers;
     std::string redirectUrl;
@@ -305,12 +304,6 @@ int main(int argc, char** argv)
     redisServerApp->add_option("--port", port, "Port");
     redisServerApp->add_option("--host", hostname, "Hostname");
 
-    CLI::App* proxyServerApp = app.add_subcommand("proxy_server", "Proxy server");
-    proxyServerApp->add_option("--port", port, "Port");
-    proxyServerApp->add_option("--host", hostname, "Hostname");
-    proxyServerApp->add_option("--remote_host", remoteHost, "Remote Hostname");
-    proxyServerApp->add_flag("-v", verbose, "Verbose");
-
     CLI11_PARSE(app, argc, argv);
 
     // pid file handling
@@ -449,10 +442,6 @@ int main(int argc, char** argv)
     {
         ret = ix::ws_redis_server_main(port, hostname);
     }
-    else if (app.got_subcommand("proxy_server"))
-    {
-        ret = ix::ws_proxy_server_main(port, hostname, tlsOptions, remoteHost, verbose);
-    }
     else if (version)
     {
         std::cout << "ws " << ix::userAgent() << std::endl;

ws/ws.h

@@ -142,10 +142,4 @@ namespace ix
     int ws_autobahn_main(const std::string& url, bool quiet);
 
     int ws_redis_server_main(int port, const std::string& hostname);
-
-    int ws_proxy_server_main(int port,
-                             const std::string& hostname,
-                             const ix::SocketTLSOptions& tlsOptions,
-                             const std::string& remoteHost,
-                             bool verbose);
 } // namespace ix

ws/ws_cobra_metrics_to_redis.cpp

@@ -128,21 +128,23 @@ namespace ix
             {
                 spdlog::info("Subscriber authenticated");
 
-                conn.subscribe(
-                    channel,
-                    filter,
-                    [&msgPerSeconds, &msgCount, &conditionVariableMutex, &condition, &queue](
-                        const Json::Value& msg) {
-                        {
-                            std::unique_lock<std::mutex> lock(conditionVariableMutex);
-                            queue.push(msg);
-                        }
+                conn.subscribe(channel,
+                               filter,
+                               [&msgPerSeconds,
+                                &msgCount,
+                                &conditionVariableMutex,
+                                &condition,
+                                &queue](const Json::Value& msg) {
+                                   {
+                                       std::unique_lock<std::mutex> lock(conditionVariableMutex);
+                                       queue.push(msg);
+                                   }
 
-                        condition.notify_one();
+                                   condition.notify_one();
 
-                        msgPerSeconds++;
-                        msgCount++;
-                    });
+                                   msgPerSeconds++;
+                                   msgCount++;
+                               });
             }
             else if (eventType == ix::CobraConnection_EventType_Subscribed)
             {

ws/ws_cobra_to_sentry.cpp

@@ -4,12 +4,12 @@
  *  Copyright (c) 2019 Machine Zone, Inc. All rights reserved.
  */
 
+#include <ixsentry/IXSentryClient.h>
 #include <atomic>
 #include <chrono>
 #include <condition_variable>
 #include <iostream>
 #include <ixcobra/IXCobraConnection.h>
-#include <ixsentry/IXSentryClient.h>
 #include <mutex>
 #include <queue>
 #include <spdlog/spdlog.h>

ws/ws_echo_server.cpp

@@ -1,5 +1,5 @@
 /*
- *  ws_echo_server.cpp
+ *  ws_broadcast_server.cpp
  *  Author: Benjamin Sergeant
  *  Copyright (c) 2018 Machine Zone, Inc. All rights reserved.
  */

ws/ws_proxy_server.cpp

@@ -1,174 +0,0 @@
-/*
- *  ws_proxy_server.cpp
- *  Author: Benjamin Sergeant
- *  Copyright (c) 2018 Machine Zone, Inc. All rights reserved.
- */
-
-#include <iostream>
-#include <ixwebsocket/IXWebSocketServer.h>
-#include <sstream>
-
-namespace ix
-{
-    class ProxyConnectionState : public ix::ConnectionState
-    {
-    public:
-        ProxyConnectionState()
-            : _connected(false)
-        {
-        }
-
-        ix::WebSocket& webSocket()
-        {
-            return _serverWebSocket;
-        }
-
-        bool isConnected()
-        {
-            return _connected;
-        }
-
-        void setConnected()
-        {
-            _connected = true;
-        }
-
-    private:
-        ix::WebSocket _serverWebSocket;
-        bool _connected;
-    };
-
-    int ws_proxy_server_main(int port,
-                             const std::string& hostname,
-                             const ix::SocketTLSOptions& tlsOptions,
-                             const std::string& remoteUrl,
-                             bool verbose)
-    {
-        std::cout << "Listening on " << hostname << ":" << port << std::endl;
-
-        ix::WebSocketServer server(port, hostname);
-        server.setTLSOptions(tlsOptions);
-
-        auto factory = []() -> std::shared_ptr<ix::ConnectionState> {
-            return std::make_shared<ProxyConnectionState>();
-        };
-        server.setConnectionStateFactory(factory);
-
-        server.setOnConnectionCallback([remoteUrl,
-                                        verbose](std::shared_ptr<ix::WebSocket> webSocket,
-                                                 std::shared_ptr<ConnectionState> connectionState) {
-            auto state = std::dynamic_pointer_cast<ProxyConnectionState>(connectionState);
-
-            // Server connection
-            state->webSocket().setOnMessageCallback([webSocket, state, verbose](
-                                                        const WebSocketMessagePtr& msg) {
-                if (msg->type == ix::WebSocketMessageType::Open)
-                {
-                    std::cerr << "New connection" << std::endl;
-                    std::cerr << "server id: " << state->getId() << std::endl;
-                    std::cerr << "Uri: " << msg->openInfo.uri << std::endl;
-                    std::cerr << "Headers:" << std::endl;
-                    for (auto it : msg->openInfo.headers)
-                    {
-                        std::cerr << it.first << ": " << it.second << std::endl;
-                    }
-                }
-                else if (msg->type == ix::WebSocketMessageType::Close)
-                {
-                    std::cerr << "Closed connection"
-                              << " code " << msg->closeInfo.code << " reason "
-                              << msg->closeInfo.reason << std::endl;
-                    webSocket->close(msg->closeInfo.code, msg->closeInfo.reason);
-                    state->setTerminated();
-                }
-                else if (msg->type == ix::WebSocketMessageType::Error)
-                {
-                    std::stringstream ss;
-                    ss << "Connection error: " << msg->errorInfo.reason << std::endl;
-                    ss << "#retries: " << msg->errorInfo.retries << std::endl;
-                    ss << "Wait time(ms): " << msg->errorInfo.wait_time << std::endl;
-                    ss << "HTTP Status: " << msg->errorInfo.http_status << std::endl;
-                    std::cerr << ss.str();
-                }
-                else if (msg->type == ix::WebSocketMessageType::Message)
-                {
-                    std::cerr << "Received " << msg->wireSize << " bytes from server" << std::endl;
-                    if (verbose)
-                    {
-                        std::cerr << "payload " << msg->str << std::endl;
-                    }
-
-                    webSocket->send(msg->str, msg->binary);
-                }
-            });
-
-            // Client connection
-            webSocket->setOnMessageCallback([state, remoteUrl, verbose](
-                                                const WebSocketMessagePtr& msg) {
-                if (msg->type == ix::WebSocketMessageType::Open)
-                {
-                    std::cerr << "New connection" << std::endl;
-                    std::cerr << "client id: " << state->getId() << std::endl;
-                    std::cerr << "Uri: " << msg->openInfo.uri << std::endl;
-                    std::cerr << "Headers:" << std::endl;
-                    for (auto it : msg->openInfo.headers)
-                    {
-                        std::cerr << it.first << ": " << it.second << std::endl;
-                    }
-
-                    // Connect to the 'real' server
-                    std::string url(remoteUrl);
-                    url += msg->openInfo.uri;
-                    state->webSocket().setUrl(url);
-                    state->webSocket().start();
-
-                    // we should sleep here for a bit until we've established the
-                    // connection with the remote server
-                    while (state->webSocket().getReadyState() != ReadyState::Open)
-                    {
-                        std::cerr << "waiting for server connection establishment" << std::endl;
-                        std::this_thread::sleep_for(std::chrono::milliseconds(10));
-                    }
-                    std::cerr << "server connection established" << std::endl;
-                }
-                else if (msg->type == ix::WebSocketMessageType::Close)
-                {
-                    std::cerr << "Closed connection"
-                              << " code " << msg->closeInfo.code << " reason "
-                              << msg->closeInfo.reason << std::endl;
-                    state->webSocket().close(msg->closeInfo.code, msg->closeInfo.reason);
-                }
-                else if (msg->type == ix::WebSocketMessageType::Error)
-                {
-                    std::stringstream ss;
-                    ss << "Connection error: " << msg->errorInfo.reason << std::endl;
-                    ss << "#retries: " << msg->errorInfo.retries << std::endl;
-                    ss << "Wait time(ms): " << msg->errorInfo.wait_time << std::endl;
-                    ss << "HTTP Status: " << msg->errorInfo.http_status << std::endl;
-                    std::cerr << ss.str();
-                }
-                else if (msg->type == ix::WebSocketMessageType::Message)
-                {
-                    std::cerr << "Received " << msg->wireSize << " bytes from client" << std::endl;
-                    if (verbose)
-                    {
-                        std::cerr << "payload " << msg->str << std::endl;
-                    }
-                    state->webSocket().send(msg->str, msg->binary);
-                }
-            });
-        });
-
-        auto res = server.listen();
-        if (!res.first)
-        {
-            std::cerr << res.second << std::endl;
-            return 1;
-        }
-
-        server.start();
-        server.wait();
-
-        return 0;
-    }
-} // namespace ix